918187 - Exports should be done during incremental builds

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We seem to no longer be exporting header files when we do incremental builds. We used to do this, but now we don't. This is terrible. It means when I change a header file that's exported I need to rebuild the entire source tree before the change (or an error...) is reflected. On Windows the build is very slow, even on the best hardware that money can buy. Agonizingly slow.

Please put the export step back into incremental builds.

Comment 1

[Mike Hommey [:glandium] OoO until Jun 18]

I guess you mean partial, not incremental, right?

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

I mean `./mach build dir/dir2`, so if that means partial, sure. I'm not a build expert.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This combined with the lack of symlinks is making it impossible to do anything other than toplevel builds on windows.  Can we please get this fixed?

Comment 4

[Mike Hommey [:glandium] OoO until Jun 18]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #3)
> This combined with the lack of symlinks is making it impossible to do
> anything other than toplevel builds on windows.

That is a surprising claim, actually. Unmodified headers should be left untouched by install manifests.

Comment 5

[Mike Hommey [:glandium] OoO until Jun 18]

(In reply to Mike Hommey [:glandium] from comment #4)
> (In reply to Kyle Huey [:khuey] ([e-mail]) from comment #3)
> > This combined with the lack of symlinks is making it impossible to do
> > anything other than toplevel builds on windows.
> 
> That is a surprising claim, actually. Unmodified headers should be left
> untouched by install manifests.

Ah, the problem might be that nspr and mfbt are always new after make export...

Comment 6

[Mike Hommey [:glandium] OoO until Jun 18]

(In reply to Mike Hommey [:glandium] from comment #5)
> Ah, the problem might be that nspr and mfbt are always new after make
> export...

as well as mozilla-config.h.

So *that* would be what to fix.

Comment 7

[Gregory Szorc [:gps]]

Workaround:

NO_REMOVE=1 mach build install-manifests

Comment 8

[Gregory Szorc [:gps]]

Marking WORKSFORME because `mach build binaries` makes this workflow reasonable.