918192 - [email] POP3 support: Port Thunderbird POP3 fake-server to mail-fakeservers

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

Thunderbird has a POP3 fake-server that we should be able to integrate with our existing fake-server implementations pretty easily.  Although for bug 916080 we really only need authentication, I think we can get most of it from this.

Comment 1

[Marcus Cavanaugh [:mcav]]

Attachment: mail-fakeservers pull request

Comment 2

[Marcus Cavanaugh [:mcav]]

(Also see bug 832924, where the GELAM and Gaia pull requests live)

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 828419 [details]
mail-fakeservers pull request

Awesome.  One glitch though; you did break some ActiveSync tests.  You need to make this fix:

diff --git a/xpcom/subscript/mime.jsm b/xpcom/subscript/mime.jsm
index 7755819..174bceb 100644
--- a/xpcom/subscript/mime.jsm
+++ b/xpcom/subscript/mime.jsm
@@ -12,7 +12,7 @@ Components.utils.import("resource://fakeserver/modules/mimeParser.jsm");
  */
 this.convertRfc2822RepToMessageRep =
 function convertRfc2822RepToMessageRep(mimestr) {
-  if (mimestr instanceof Uint8Array)
+  if (typeof(mimestr) !== 'string')
     mimestr = String.fromCharCode.apply(undefined, mimestr);

The reason is a new (to you) and exciting foot-gun you might not be familiar with: each JSM file gets its own set of globals which breaks instanceof.  It worked before when the code was in activesync_server.js because they had the same global.  (nb: We probably should be using TextDecoder there too, but it was that way before so let's just leave it for now.)

Anywho, please make that change, bump the revision to 0.0.7 and push a new release to npm.  Since the tests pass with this updated version, we might as well land it immediately.

Comment 4

[Marcus Cavanaugh [:mcav]]

Awesome, that's pretty obscure. Glad to see all the tests green again.

Landed in mail-fakeservers, version-bumped to 0.0.7 on npm:

https://github.com/mozilla-b2g/mail-fakeservers/commit/5c761c45aa92492fe1ec44c23288dad59884089d