Closed
Bug 918221
Opened 11 years ago
Closed 11 years ago
OscillatorNode is CC'd before it has finished playing
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(1 file)
|
3.32 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
This patch depends on bug 918213 to ensure that NotifyMainThreadStateChanged() is called and the OscillatorNode patch in bug 914033 to provide a means other than stop() to remove the playing ref when the window is finished.
Attachment #807078 -
Flags: review?(ehsan)
|
Assignee | |
Updated•11 years ago
|
Attachment #807078 -
Attachment description: t remove OscillatorNode playing ref on stop() but wait until finished → don't remove OscillatorNode playing ref on stop() but wait until finished
|
||
Comment 1•11 years ago
|
||
Comment on attachment 807078 [details] [diff] [review]
don't remove OscillatorNode playing ref on stop() but wait until finished
Review of attachment 807078 [details] [diff] [review]:
-----------------------------------------------------------------
Nice test!
Attachment #807078 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Comment 3•11 years ago
|
||
Flags: in-testsuite+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•