Closed Bug 918267 Opened 11 years ago Closed 11 years ago

orange: test-session-store.js | test-session-store.js::test_clean_shutdown_session_persistence_simple

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird26 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 27.0
Tracking Flags:
Tracking Status
thunderbird26 --- fixed

People

(Reporter: mkmelin, Assigned: hiro)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Fix
1.15 KB, patch
standard8
: review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review 
(Maybe related to bug 918261 as they both seem to have popped up at the same time).
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/session-store/test-session-store.js | test-session-store.js::teardownModule

SUMMARY-UNEXPECTED-FAIL | test-session-store.js | test-session-store.js::test_clean_shutdown_session_persistence_simple
  EXCEPTION: loadedState is null
    at: test-session-store.js line 435
       test_clean_shutdown_session_persistence_simple test-session-store.js 435
       Runner.prototype.wrapper frame.js 585
       Runner.prototype._runTestModule frame.js 655
       Runner.prototype.runTestModule frame.js 701
       Runner.prototype.runTestDirectory frame.js 525
       runTestDirectory frame.js 707
       Bridge.prototype._execFunction server.js 179
       Bridge.prototype.execFunction server.js 183
SUMMARY-UNEXPECTED-FAIL | test-session-store.js | test-session-store.js::teardownModule
  EXCEPTION: mc.tabmail.tabInfo is undefined
    at: test-folder-display-helpers.js line 353
       teardownModule test-folder-display-helpers.js 353
       Runner.prototype.wrapper frame.js 580
       Runner.prototype._runTestModule frame.js 677
       Runner.prototype.runTestModule frame.js 701
       Runner.prototype.runTestDirectory frame.js 525
       runTestDirectory frame.js 707
       Bridge.prototype._execFunction server.js 179
       Bridge.prototype.execFunction server.js 183
I just did a bisect on this, bisect said:

The first bad revision is:
changeset:   155411:e1bed78a75d6
user:        Bobby Holley <bobbyholley@gmail.com>
date:        Tue Sep 17 17:45:48 2013 -0400
summary:     Bug 874502 - Part 6: Remove IsCallerChrome path for tearing down windows synchronously. r=bzbarsky, a=lsblakk

My suspicion is that if window close are now async, that's probably broken the tests or the code.
Blocks: 874502
Attached patch Fix — — Splinter Review 
Use close_window() instead of window.close() to wait for closing the window.
Attachment #808951 - Flags: review?(mbanner)
try server results:
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=6cc95bc70153

test-message-header.js failed, but I don't think it is related to the fix for this bug because test-message-header.js is in a different directory(message-header/).
Comment on attachment 808951 [details] [diff] [review]
Fix

Excellent, thanks.
Attachment #808951 - Flags: review?(mbanner) → review+
Assignee: nobody → hiikezoe
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/7e074f80d067
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 27.0
Comment on attachment 808951 [details] [diff] [review]
Fix

[Triage Comment]
Taking to aurora as we need this there.
Attachment #808951 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: