Closed
Bug 918295
Opened 11 years ago
Closed 11 years ago
|APP=... make install-gaia| activate too many targets in the build system
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vingtetun, Assigned: vingtetun)
Details
Attachments
(1 file)
7.65 KB,
patch
|
yurenju
:
review+
|
Details | Diff | Splinter Review |
When doing |APP=homescreen make install-gaia| there is way too many targets that are fired by the build system. This results into a painful log as well as additional developer time spent for each flash. Can we fix the build system to have something similar to the output returned with the attached patch when someone do |APP=homescreen make install-gaia| ? Here is the time spent on my machine without the patch: real 0m3.274s user 0m0.748s sys 0m0.316s And here the time spent with the patch: real 0m1.752s user 0m0.416s sys 0m0.136s One can argue that it is no a big win, but so many persons are loosing 1.5 seconds everytime that it ends up beeing a long time...
Flags: needinfo?(yurenju.mozilla)
Comment 1•11 years ago
|
||
Comment on attachment 807170 [details] [diff] [review] build.patch oh this patch looks great and so fast! r=yurenju
Attachment #807170 -
Flags: review+
Updated•11 years ago
|
Flags: needinfo?(yurenju.mozilla)
Comment 2•11 years ago
|
||
merged. https://github.com/mozilla-b2g/gaia/commit/5b9908a8f7285333feb20efb7d7939d0033b0fea
Assignee: yurenju.mozilla → 21
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•