[Followup 900443][SMS] Add a robust check when retrieving a contact from activity.

RESOLVED FIXED

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: borjasalguero, Assigned: borjasalguero)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 fixed)

Details

(Whiteboard: [u=commsapps-user c=contacts p=0])

Attachments

(1 attachment)

Assignee: nobody → fbsc
Depends on: 900443
Followup of a Koi+, should be koi+ as well.
blocking-b2g: --- → koi?
Posted file Pull Request
Attachment #807180 - Flags: review?(felash)
Comment on attachment 807180 [details]
Pull Request

r=me

thanks
Attachment #807180 - Flags: review?(felash) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [u=commsapps-user c=contacts p=0]
Joe, can you please mark this bug koi+, this is a follow-up og koi+ bug 900443. Thanks !
Flags: needinfo?(jcheng)
blocking-b2g: koi? → koi+
Flags: needinfo?(jcheng)
I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 132dd57b5cffa7cc000447f8457892b92d7979fc
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(borja.bugzilla)
John, I think this was landed here in v1.2:
https://github.com/mozilla-b2g/gaia/commit/3f318a0c728a319d9eea927c0275d2e480d36e6f
Could you take a look? Thanks!
Flags: needinfo?(borja.bugzilla) → needinfo?(jhford)
Borja: if you did it, then it's ok

Next time, you should write here the master and v1.2 hashes, and set the correct flags (as I do in this comment).

master: 132dd57b5cffa7cc000447f8457892b92d7979fc
v1.2: 3f318a0c728a319d9eea927c0275d2e480d36e6f
Flags: needinfo?(jhford)
You need to log in before you can comment on or make changes to this bug.