918318 - Add support for src in webactivities

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect)

Description

[Wil Clouser [:clouserw]]

This bug is kind of an RFC, but also seems like a good idea.  What do you think of accepting a src in webactivities.  Mat pointed me to https://github.com/mozilla/fireplace/commit/035f425#L3R22 where we hardcode src=webactivities.  What if we did:

if (data.src) {
  src = clean(data.src) //[a-zA-Z0-9._-] would be fine
} else {
  src = "webactivities"
}

and then it could be overridden by whatever is passed in.  Thoughts?

Comment 1

[Christopher Van Wiemeersch [:cvan]]

(In reply to Wil Clouser [:clouserw] from comment #0)
> and then it could be overridden by whatever is passed in.  Thoughts?

Yeah we can totally do this, but "passed in" from where? What do we want to track? What's the use case?

IMO we probably want to track the activity name (e.g., `webactivities-app`)?

Comment 2

[Wil Clouser [:clouserw]]

Basically I was trying to get "e.me" as a source in our stats and I figured we could just ask them to add src=e.me somewhere in their call to us.  There is potential for abuse there, I suppose, so we could prefix it with WA- or something?  /me catching flight and have to run but can talk more l8r!

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Ohhh, yeah we can do this and it's totally something we should do.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/bbc4bf3