Add support for src in webactivities

RESOLVED FIXED in 2013-09-24

Status

Marketplace
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: clouserw, Assigned: cvan)

Tracking

2013-09-24
Points:
---

Details

(Whiteboard: [qa-])

(Reporter)

Description

5 years ago
This bug is kind of an RFC, but also seems like a good idea.  What do you think of accepting a src in webactivities.  Mat pointed me to https://github.com/mozilla/fireplace/commit/035f425#L3R22 where we hardcode src=webactivities.  What if we did:

if (data.src) {
  src = clean(data.src) //[a-zA-Z0-9._-] would be fine
} else {
  src = "webactivities"
}

and then it could be overridden by whatever is passed in.  Thoughts?
(Assignee)

Comment 1

5 years ago
(In reply to Wil Clouser [:clouserw] from comment #0)
> and then it could be overridden by whatever is passed in.  Thoughts?

Yeah we can totally do this, but "passed in" from where? What do we want to track? What's the use case?

IMO we probably want to track the activity name (e.g., `webactivities-app`)?
(Reporter)

Comment 2

5 years ago
Basically I was trying to get "e.me" as a source in our stats and I figured we could just ask them to add src=e.me somewhere in their call to us.  There is potential for abuse there, I suppose, so we could prefix it with WA- or something?  /me catching flight and have to run but can talk more l8r!
(Assignee)

Comment 3

5 years ago
Ohhh, yeah we can do this and it's totally something we should do.
Assignee: nobody → cvan
Target Milestone: --- → 2013-09-24
(Assignee)

Comment 4

5 years ago
https://github.com/mozilla/fireplace/commit/bbc4bf3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.