918347 - [contacts] refactor CSS to support improve load time

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

Bug 918174 made the quick and easy fix to avoid style recomputations when lazy loading CSS in contacts.  We should spend more time, however, to determine if the app can be refactored to better defer these loads.  For example, can the progress.css be deferred until the first time a progress overlay is needed, etc.

In addition, we should investigate using scoped styles where possible to minimize the recomputations that are needed when the style sheets are loaded.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

It does seem that bug 918174 regressed opening a single contact via web activity (e.g. from call log).  We may want to prioritize this for 1.2.

Comms team, what do you think?  Are you open to this kind of refactoring given the other work going on at the moment?

Comment 2

[Jose Manuel Cantera]

my advice here is to backout bug 918174. Major refactoring work should happen in 1.3 and not in 1.2

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Jose M. Cantera from comment #2)
> my advice here is to backout bug 918174. Major refactoring work should
> happen in 1.3 and not in 1.2

Ok.  I'll do the backout.  Are you open to an intermediate solution that moves the CSS loads around without too much refactoring?  (I know that's hard to answer without seeing patches...)

Comment 4

[Jose Manuel Cantera]

I'm open to patches provided the demosntrate a clear performance win

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

So bug 918174 was backed out, but then I investigated the regression and realized it was not actually there.  So in the end bug 918174 did land.

Leaving this bug open to track possibly refactoring the CSS loading in the future.  Dropping koi? nom based on comment 2.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Updating title to reflect that this is more about refactoring the style sheets to improve load times.

Comment 7

[Jose Manuel Cantera]

are we going to nom this for v1.3?

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Jose M. Cantera from comment #7)
> are we going to nom this for v1.3?

It sounds like that may be a good idea along with potentially other perf related refactoring.  Is 1.3 a good time to do that?  I guess nom'ing is the way to answer that.

Thanks!

Comment 9

[Mike Lee [:mlee]]

fxos-perf-triage: David, theses changes would be significant for the Contacts app so the Comms Apps team should make the call on whether to 1.3+ this. Please assign someone and decide whether to + or - this for 1.3.

Comment 10

[David Scravaglieri [:scravag]]

Jose, what's your advice on this ?

Comment 11

[Jose Manuel Cantera]

I think we should definetely work on this on v1.3

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

triage: not blocking 1.3 release. please land in master when ready. thanks

Comment 13

[Ben Kelly [:bkelly, not reviewing]]

Based on the investigation Doug did in bug 996776 I think we can probably mark this WONTFIX as well.