918388 - Enable Synth Web Speech API in pref

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Eitan Isaacson [:eeejay]]

So far, I only think it should be on by default in b2g since that is the only app we ship voices for.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Enable Synth Web Speech API pref in b2g

Don't know who should review this, hub should do :)

Comment 2

[Cervantes Yu [:cyu] [:cervantes]]

Hi Eitan,

I found that the nsPicoService is registered with the "app-startup" category. nsPicoService gets instantiated in each content process, which looks to be unnecessary. Is there any reason for starting up on app startup? If not then we should consider instantiate the service only when necessary.

Comment 3

[Marco Zehe (:MarcoZ)]

(In reply to Cervantes Yu from comment #2)
> I found that the nsPicoService is registered with the "app-startup"
> category. nsPicoService gets instantiated in each content process, which
> looks to be unnecessary. Is there any reason for starting up on app startup?
> If not then we should consider instantiate the service only when necessary.

This is being dealt with in bug 918989.

Comment 4

[Masatoshi Kimura [:emk]]

(In reply to Eitan Isaacson [:eeejay] from comment #1)
> Created attachment 809597 [details] [diff] [review]
> Enable Synth Web Speech API pref in b2g
> 
> Don't know who should review this, hub should do :)

Please update dom/tests/mochitest/general/test_interfaces.html and ask a DOM peer for review.

Comment 5

[Hubert Figuiere [:hub]]

Comment on attachment 809597 [details] [diff] [review]
Enable Synth Web Speech API pref in b2g

I would have picked Fabrice instead. I am not peer.

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Enable Synth Web Speech API pref in b2g

Added interface test, and sent to try:
https://tbpl.mozilla.org/?tree=Try&rev=16e7823cd036

Comment 7

[Eitan Isaacson [:eeejay]]

Comment on attachment 810057 [details] [diff] [review]
Enable Synth Web Speech API pref in b2g

The try results look good enough.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 810057 [details] [diff] [review]
Enable Synth Web Speech API pref in b2g

I guess it would be good to get some memory usage stats.

Comment 9

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c85c2981bc8d

Comment 10

[Eitan Isaacson [:eeejay]]

(In reply to Olli Pettay [:smaug] from comment #8)
> Comment on attachment 810057 [details] [diff] [review]
> Enable Synth Web Speech API pref in b2g
> 
> I guess it would be good to get some memory usage stats.

How do we go about that?

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Don't we have about:memory on b2g too? What is the memusage before the patch after the patch?

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c85c2981bc8d