Enable Synth Web Speech API in pref

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

(Blocks: 1 bug, {access})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
So far, I only think it should be on by default in b2g since that is the only app we ship voices for.
(Assignee)

Comment 1

5 years ago
Created attachment 809597 [details] [diff] [review]
Enable Synth Web Speech API pref in b2g

Don't know who should review this, hub should do :)
Attachment #809597 - Flags: review?(hub)
Hi Eitan,

I found that the nsPicoService is registered with the "app-startup" category. nsPicoService gets instantiated in each content process, which looks to be unnecessary. Is there any reason for starting up on app startup? If not then we should consider instantiate the service only when necessary.
Flags: needinfo?(eitan)

Comment 3

5 years ago
(In reply to Cervantes Yu from comment #2)
> I found that the nsPicoService is registered with the "app-startup"
> category. nsPicoService gets instantiated in each content process, which
> looks to be unnecessary. Is there any reason for starting up on app startup?
> If not then we should consider instantiate the service only when necessary.

This is being dealt with in bug 918989.
Flags: needinfo?(eitan)
(In reply to Eitan Isaacson [:eeejay] from comment #1)
> Created attachment 809597 [details] [diff] [review]
> Enable Synth Web Speech API pref in b2g
> 
> Don't know who should review this, hub should do :)

Please update dom/tests/mochitest/general/test_interfaces.html and ask a DOM peer for review.
Comment on attachment 809597 [details] [diff] [review]
Enable Synth Web Speech API pref in b2g

I would have picked Fabrice instead. I am not peer.
Attachment #809597 - Flags: review?(hub) → review?(fabrice)
(Assignee)

Comment 6

5 years ago
Created attachment 810057 [details] [diff] [review]
Enable Synth Web Speech API pref in b2g

Added interface test, and sent to try:
https://tbpl.mozilla.org/?tree=Try&rev=16e7823cd036
Attachment #809597 - Attachment is obsolete: true
Attachment #809597 - Flags: review?(fabrice)
(Assignee)

Comment 7

5 years ago
Comment on attachment 810057 [details] [diff] [review]
Enable Synth Web Speech API pref in b2g

The try results look good enough.
Attachment #810057 - Flags: review?(fabrice)
Attachment #810057 - Flags: review?(bugs)
Attachment #810057 - Flags: review?(fabrice) → review+

Comment 8

5 years ago
Comment on attachment 810057 [details] [diff] [review]
Enable Synth Web Speech API pref in b2g

I guess it would be good to get some memory usage stats.
Attachment #810057 - Flags: review?(bugs) → review+
(Assignee)

Comment 10

5 years ago
(In reply to Olli Pettay [:smaug] from comment #8)
> Comment on attachment 810057 [details] [diff] [review]
> Enable Synth Web Speech API pref in b2g
> 
> I guess it would be good to get some memory usage stats.

How do we go about that?
Don't we have about:memory on b2g too? What is the memusage before the patch after the patch?
https://hg.mozilla.org/mozilla-central/rev/c85c2981bc8d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.