Closed Bug 918390 Opened 6 years ago Closed 6 years ago
[Contacts] No error when selecting a contact with no number for Messages app contact requests
Description: When a user is composing a message, taps the "To" field and tries to select a contact that doesn't have a number, no error message is given. Repro Steps: 1) Updated to Buri Build ID: 20130916040205 2) Add a contact that doesn't have a phone number. (Name only) 3) Tap on the "SMS" icon to open messaging. 4) Tap on the "Compose New Message" icon. 5) Tap the "+" button to add a contact to the "To" field. 6) Tap on the contact that doesn't have a number associated with it. Actual: The user is not given an error message when selecting a contact that doesn't have an phone number attached to it. They will tap on the contact and nothing will occur. Expected: When the user tries to add a contact that doesn't have a number attached to it, an error message is prompted. Environmental Variables Build ID: 20130916040205 Gecko: http://hg.mozilla.org/mozilla-central/rev/c4bcef90cef9 Gaia: a0079597d510ce8ea0b9cbb02c506030510b9eeb Platform Version: 26.0a1 Notes: Repro frequency: (100%) Test Suite Name: (SMS) UCID: (messages-001) Link to failed test case: https://moztrap.mozilla.org/manage/case/7892/ See attached: (screenshot)
That's not controlled by Messages app.
Component: Gaia::SMS → Gaia::Contacts
Summary: [B2G][SMS] No error message is given when selecting a contact without a number → [Contacts] No error when selecting a contact with no number for Messages app contact requests
Between builds 09/12 and 09/13 appears to be where the issue was introduced: Build ID: 20130912040201 Gecko: http://hg.mozilla.org/mozilla-central/rev/a98569f21abe Gaia: 9ffd2899eb91388f7fc1ce6f7a895a6f5f922c05 Platform Version: 26.0a1 Build ID: 20130913040201 Gecko: http://hg.mozilla.org/mozilla-central/rev/b9029b1de410 Gaia: 8ccb741b6adcfe9a78b842c17e5874242c0f8b86 Platform Version: 26.0a1 On 09/12 a message shows up, but on 09/13 no message appears when selecting a contact for an sms without a number.
We're now using a new activity "webcontacts/tel" when picking a contact in the Messages app (bug 900443), therefore the Contacts app should now be able to filter the contacts without a number when it answers this activity.
triage: koi+ for regression
blocking-b2g: koi? → koi+
another regression of our DOM Lazy Load friends
Comment on attachment 812592 [details] 12573.html :) Nice catch.
Attachment #812592 - Flags: review?(francisco.jordano) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Uplifted 7447624c24ce442394273b9d54d5f0cb20642a17 to: v1.2: a4504b01fd3c664bfe43fde8740d52fc55d0ff06
Error message "This contact does not have a phone number" when performing STR from comment 0. Verifying v1.2 as fixed on: Gaia 922de46ad5e4a8b513b24233a7f3bc54b93e9612 SourceStamp 2664ac296982 BuildID 20131018004000 Version 26.0a2 base image: 20131015
You need to log in before you can comment on or make changes to this bug.