918393 - Characters should be preserved when asking a question.

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P2)

Description

[Kadir Topal [:atopal]]

Certain characters in the title of a question are escaped when the question is posted to the forum. This is true for the apostrophe. ' -> %27 but also for non-ascii characters like ö --> %C3%B6. those characters should not be escaped.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

This _only_ happens for users that are using the fallback persona auth provider and they click on the link in their email to confirm the persona account.

Is that right Kadir?

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Looks like we are giving persona this:
http://localhost:8000/en-US/questions/new/desktop/get-started/form?search=test%27ng+th%C3%ADs+%C3%BC&step=aaq-register

And it is coming back with:
http://localhost:8000/en-US/questions/new/desktop/get-started/form?search=test%2527ng+th%25C3%25ADs+%25C3%25BC&step=aaq-register

So, basically it is re-encoding our url parameters. ewww

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

I filed persona bug for this:

https://github.com/mozilla/browserid/issues/3903

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

Making this 1pt for the research into it. Looks like we have to sit and wait for persona to fix it.

Comment 5

[Kadir Topal [:atopal]]

Yeah, using gmail there is no problem. Unfortunately only 1/3 of our newly registering users are Gmail users. We can tolerate this for a while on the en-US forums and correct titles manually, but it might be a show stopper for Portuguese. Almost all questions have non ascii characters in them. Their titles would be almost unreadable with this bug.

Comment 6

[Kadir Topal [:atopal]]

Is there any workaround, that we could employ in the meantime, Ricky?

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

There is nothing we can do for this, it all happens in the persona code.

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #7)
> There is nothing we can do for this, it all happens in the persona code.

Actually, there is. If we `decodeURI` the URL before passing it to `navigator.id.request()`, everything works out.

Landed workaround on master:

https://github.com/mozilla/kitsune/commit/01ccf094d85de87722e0f69ab611248ce7bdc0c3

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod, but it only affects stage right now.