Closed Bug 918414 Opened 11 years ago Closed 10 years ago

Add support for win64+gpo platform

Categories

(Infrastructure & Operations Graveyard :: CIDuty, task)

x86
Windows Server 2008
task
Not set
normal

Tracking

(firefox26 fixed, firefox27 fixed, firefox-esr24 fixed, b2g-v1.2 fixed)

RESOLVED FIXED
Tracking Status
firefox26 --- fixed
firefox27 --- fixed
firefox-esr24 --- fixed
b2g-v1.2 --- fixed

People

(Reporter: jhopkins, Assigned: jhopkins)

References

Details

Attachments

(5 files, 4 obsolete files)

2.50 KB, patch
rail
: review+
jhopkins
: checked-in+
Details | Diff | Splinter Review
616 bytes, patch
rail
: review+
jhopkins
: checked-in+
Details | Diff | Splinter Review
39.34 KB, patch
bhearsum
: review+
jhopkins
: checked-in+
Details | Diff | Splinter Review
1.77 KB, patch
catlee
: review+
jhopkins
: checked-in+
Details | Diff | Splinter Review
3.27 KB, patch
bhearsum
: review+
jhopkins
: checked-in+
Details | Diff | Splinter Review
      No description provided.
add win64-gpo platform.  defaulted to disabling the changes on all branches so we can land this patch ahead of actually enabling the platform to avoid bitrot.
Attachment #807316 - Flags: review?(bhearsum)
Comment on attachment 807316 [details] [diff] [review]
[buildbot-configs] add win64-gpo platform, defaulting to disabled on all branches

Review of attachment 807316 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine overall, just a couple of minor things noted below.

::: mozilla/b2g_config.py
@@ +1124,5 @@
>  
> +# MERGE DAY
> +# Migrate branches to win64-gpo platform
> +for branch in BRANCHES:
> +    if True: #branch in ('mozilla-aurora','mozilla-b2g18_v1_0_1','mozilla-b2g18_v1_1_0_hd'):

This "if True" obviously needs to go. You should also update and make use of the new "items_before" helper so that you don't need to list specific branches here. Same goes for the similar blocks in other configs.

::: mozilla/production_config.py
@@ +14,5 @@
>      'linux':            LINUX_VMS + LINUX_IXS,
>      'linux64':          LINUX64_IXS,
>      'win32':            WIN32_IXS,
>      'win64':            WIN64_IXS,
> +    'win64-gpo':        WIN64_GPO,

Is there a different name we can use for these? GPO is a technology, and I don't think it makes much sense to put in the slave class. Even something like win64-rev2 would be better IMO.
Attachment #807316 - Flags: review?(bhearsum) → review-
Renamed platform to win64-rev2, removed the commented-out branch names.

Depending on how we want to roll out this platform (eg. on a project branch first), we may want to initially list branch names, then move to the "items-before" branch selection that you suggested.
Attachment #807316 - Attachment is obsolete: true
Attachment #807404 - Flags: review?(bhearsum)
Comment on attachment 807404 [details] [diff] [review]
[buildbot-configs] add win64-gpo platform, defaulting to disabled on all branches

Review of attachment 807404 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to John Hopkins (:jhopkins) from comment #3)
> Created attachment 807404 [details] [diff] [review]
> [buildbot-configs] add win64-gpo platform, defaulting to disabled on all
> branches
> 
> Renamed platform to win64-rev2, removed the commented-out branch names.
> 
> Depending on how we want to roll out this platform (eg. on a project branch
> first), we may want to initially list branch names, then move to the
> "items-before" branch selection that you suggested.

I'm not fussy on what we do mid-rollout as long as we keep it as clean as possible in the end.
Attachment #807404 - Flags: review?(bhearsum) → review+
This will need to be landed and synced before the buildbot-configs patch lands.
Attachment #807411 - Flags: review?(rail)
Attachment #807411 - Flags: review?(rail) → review+
Comment on attachment 807411 [details] [diff] [review]
[puppet] add win64-rev2 platform to build and try BuildSlaves.py

https://hg.mozilla.org/build/puppet/rev/20d8ed18a81a
Attachment #807411 - Flags: checked-in+
Comment on attachment 807404 [details] [diff] [review]
[buildbot-configs] add win64-gpo platform, defaulting to disabled on all branches

https://hg.mozilla.org/build/buildbot-configs/rev/500790cdb1f0
Attachment #807404 - Flags: checked-in+
Add win64-rev2 to BuildSlaves.py.template to satisfy buildbot-configs tests.
Attachment #807743 - Flags: review?(rail)
Attachment #807743 - Flags: review?(rail) → review+
Attachment #807745 - Flags: review?(rail) → review+
Comment on attachment 807743 [details] [diff] [review]
[buildbot-configs] add win64-rev2 to BuildSlaves.py.template

https://hg.mozilla.org/build/buildbot-configs/rev/1d6be8a22dfe
Attachment #807743 - Flags: checked-in+
Comment on attachment 807745 [details] [diff] [review]
[buildbot-configs] don't allow win64-rev2 try and production hostnames to overlap

https://hg.mozilla.org/build/buildbot-configs/rev/a57e56c3de6b
Attachment #807745 - Flags: checked-in+
Attachment #807745 - Flags: checked-in+ → checked-in-
Comment on attachment 807404 [details] [diff] [review]
[buildbot-configs] add win64-gpo platform, defaulting to disabled on all branches

Backed out in https://hg.mozilla.org/build/buildbot-configs/rev/fa7c262cbd86
Attachment #807404 - Flags: checked-in+ → checked-in-
Depends on: 919528
In case we have the conversation of naming new machines in the future, here's a reference to the document we agreed on:
https://wiki.mozilla.org/ReleaseEngineering/Slave_Naming

(Since I saw this naming being used "ix-mn-w0864-XXX" which I assume it is only for experimental purposes)
This patch needs to be present on any branch that uses the win64-rev2 build slaves.
Attachment #809348 - Flags: review?(catlee)
Attachment #807404 - Attachment is obsolete: true
Attachment #807745 - Attachment is obsolete: true
Attachment #809362 - Flags: review?(bhearsum)
Attachment #809348 - Flags: review?(catlee) → review+
improved patch that we can land in advance of switching a branch to win64-rev2 build slaves
Attachment #809348 - Attachment is obsolete: true
Attachment #809392 - Flags: review?(catlee)
Attachment #809362 - Flags: review?(bhearsum) → review+
Comment on attachment 809362 [details] [diff] [review]
[buildbot-configs] win64-rev2 configuration, disabled on all branches

https://hg.mozilla.org/build/buildbot-configs/rev/96f6f2a7d3a3
Attachment #809362 - Flags: checked-in+
In production
Attachment #809392 - Flags: review?(catlee) → review+
Comment on attachment 809392 [details] [diff] [review]
[mozilla-central] look for gapi.data on c: then e:

https://hg.mozilla.org/integration/mozilla-inbound/rev/80f98d794003
Attachment #809392 - Flags: checked-in+
Attachment #809935 - Flags: review?(bhearsum) → review+
Comment on attachment 809935 [details] [diff] [review]
[buildbot-configs] enable win64-rev2 on cedar

http://hg.mozilla.org/build/buildbot-configs/rev/c208fb23c9ce

and in production.
Attachment #809935 - Flags: checked-in+
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 923200
Depends on: 925426
Depends on: 925894
Depends on: 927260
What are the next branches that we're going to target?
Depends on: 927951
'try' first, then central+inbound.  See https://groups.google.com/forum/#!topic/mozilla.dev.platform/VSgwbVIuDwg for cutover options discussion.
Depends on: 930506
No longer blocks: 781277
Depends on: 781277
Depends on: 928982
Depends on: 932961
Depends on: 933411
Depends on: 945764
Depends on: 942916
Depends on: 937823
Depends on: 937755
Depends on: 937680
Depends on: 946272
Depends on: 946275
Depends on: 920667
Depends on: 946715
Depends on: 951151
Status: REOPENED → RESOLVED
Closed: 11 years ago10 years ago
Resolution: --- → FIXED
Component: Platform Support → Buildduty
Product: Release Engineering → Infrastructure & Operations
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.