918432 - Operator apps are installed at a fixed position even when the SIM wasn't present at first boot

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Carmen Jimenez Cabezas]

STR: 
1. Flash a new phone with a build that has a GAIA_DISTRIBUTION_DIR which include some local apps (apps that must be installed only on certain SIMs
2. Boot the phone without introducing the SIM (or with a SIM that is PIN-locked, without entering the PIN).
3. After the FTU is done, shutdown the phone, introduce the SIM (if it wasn't present) and reboot

Expected: The local operator apps are installed at the end of their desired page (as the last icon of their configured pages).

Actual: The local operator apps are installed at their configured position. If there's any other icon there already, it's moved back.

Comment 1

[Carmen Jimenez Cabezas]

Attachment: Install the apps at the end of their desired screen or the first screen after that with space when the SIM isn't present at first boot

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] feature (installing single variant apps without a sim present at first boot)
[User impact] if declined: user might have configured his homescreen and he would lose his personalization
[Testing completed]: The patch includes unit tests
[Risk to taking this patch] (and alternatives if risky): Very low
[String changes made]: None

Comment 2

[Jason Smith [:jsmith]]

Fixing flags from the bug clone

Comment 3

[Cristian Rodriguez (:crdlc)]

You have some comments on github

Comment 4

[Carmen Jimenez Cabezas]

I update the PR with the review comments, can you please review it again?

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 807336 [details]
Install the apps at the end of their desired screen or the first screen after that with space when the SIM isn't present at first boot

You have three comments on Github

Thanks a lot and Great work!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 807336 [details]
Install the apps at the end of their desired screen or the first screen after that with space when the SIM isn't present at first boot

Stealing review :)

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 807336 [details]
Install the apps at the end of their desired screen or the first screen after that with space when the SIM isn't present at first boot

Please rebase before commiting :)

Thanks a lot!
F.

Comment 8

[Carmen Jimenez Cabezas]

Merged into master

https://github.com/mozilla-b2g/gaia/commit/f8b8d253112843d68fd542786f0a5d13428e2e88

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 f8b8d253112843d68fd542786f0a5d13428e2e88
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 10

[Jason Smith [:jsmith]]

Comment on attachment 807336 [details]
Install the apps at the end of their desired screen or the first screen after that with space when the SIM isn't present at first boot

Removing approval flag since this is koi+, which means it can automatically land.

Comment 11

[Cristian Rodriguez (:crdlc)]

Attachment: Patch for v1.2

Please Carmen review it because there are tones of conflicts and I am not comfortable uplifting without the author's review. Thanks

Comment 12

[Cristian Rodriguez (:crdlc)]

Landed in v1.2

https://github.com/mozilla-b2g/gaia/commit/5ef3535021286ccab7af639897feaaf5955720a0

Comment 13

[Cristian Rodriguez (:crdlc)]

Comment on attachment 814755 [details]
Patch for v1.2

r+ per comments on Github

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Cristian Rodriguez (:crdlc) from comment #12)
> Landed in v1.2
> 
> https://github.com/mozilla-b2g/gaia/commit/
> 5ef3535021286ccab7af639897feaaf5955720a0

Please make sure you set the status-b2g-v1.2 flag when landing directly on branch.

Comment 15

[Cristian Rodriguez (:crdlc)]

Ok, thanks a lot and my apologies for my mistake

Comment 16

[Jason Smith [:jsmith]]

Verified on 1.2 - comment 0's expected behavior is now confirmed working.