Implement UI dropdown language

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: alicoding, Assigned: alicoding)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Implement the dropdown language picker for login.

This bug doesn't include the remember language preference at the moment.
(Assignee)

Comment 1

5 years ago
Created attachment 807353 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/165
Attachment #807353 - Flags: review?(kieran.sedgwick)
Attachment #807353 - Flags: review?(dale)
Comment on attachment 807353 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/165

I'm gonna hit the R- on this cuz of the tests failing. Fix that and I'll review again.
Attachment #807353 - Flags: review?(kieran.sedgwick) → review-
(Assignee)

Updated

5 years ago
Attachment #807353 - Flags: review- → review?(kieran.sedgwick)

Comment 3

5 years ago
Comment on attachment 807353 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/165

Code looks good, tested locally and it didn't seem to blow up with the related wm.org patch. However, as there was only one language, I could not test the persisting of language.
Attachment #807353 - Flags: review?(dale) → review+
Comment on attachment 807353 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/165

Looks good! Get a demo up that we can see.
Attachment #807353 - Flags: review?(kieran.sedgwick) → review+
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.