918493 - Only show accept/decline for unprocessed REQUEST invitations

Status: RESOLVED FIXED

(Calendar :: Provider: Local Storage, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

STR:

A little complicated to describe. Requires a server that updates the calendar before the email invitation comes in. See also http://ci-obm.linagora.com/jira/browse/OBMFULL-5269


Steps:
1. boss invites you to a single meeting
2. boss updates the meeting date multiple times
3. calendar server updates the item in your calendar
4. you receive emails for the updates

Results:

each email shows Accept/Decline buttons

Expected:

only the latest email, i.e the one that is unprocessed should show the accept/decline buttons.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Ok, this patch takes care. Here is the new behavior. Lets say you have three invitation emails about an event you already have in your calendar (i.e updates):

Scenario 1: Server does not process invitations, you get everything via email:

- Initially, all three emails say its an update and allow accept/decline/...
- Lets say you accept the second one, but then turn it back to NEEDS-ACTION
  - The first email will say ...event that has already been processed
  - The second one says ..event that you have not yet responded to
  - The third one is again an update and allows accept/decline


Scenario 2: Server processes invitations
- As the server has processed the invitations already, the first and second 
  email will say ...event that has already been processed
- The third email matches dtstamp and will allow accept/decline

Comment 2

[Matthew Mecca [:mmecca]]

Comment on attachment 813163 [details] [diff] [review]
Fix - v1

Review of attachment 813163 [details] [diff] [review]:
-----------------------------------------------------------------

Untested with server-side processing but looks good codewise. r=mmecca

::: calendar/base/modules/calItipUtils.jsm
@@ +1207,5 @@
>                                              let foundAttendee = firstFoundItem.getAttendeeById(att.id);
>  
> +                                            // If the the user hasn't responded to the invitation yet and we
> +                                            // are viewing the current representation of the item, show the
> +                                            // accep/t/decline buttons. This means newer events will show the

There's an extra "/" in the comment.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1 (for checkin)

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1 (for checkin)

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Please land attachment 814000 [details] [diff] [review] on c-c, c-a, c-b and comm-esr24.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/e9910efb86e7
https://hg.mozilla.org/releases/comm-aurora/rev/480f026f2717
https://hg.mozilla.org/releases/comm-beta/rev/103749fcdfca
https://hg.mozilla.org/releases/comm-esr24/rev/ebfa64e6c675