918583 - operator_variant_helper.js:152 in OperatorVariantHelper.prototype.checkICCInfo: Listener threw an error! ReferenceError: settings is not defined

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Gregor Wagner [:gwagner]]

Seeing this on a nexus4 with a debug trunk build.
It has a german SIM without sim lock in it.

E/GeckoConsole(  179): Content JS ERROR at app://system.gaiamobile.org/shared/js/operator_variant_helper.js:152 in OperatorVariantHelper.prototype.checkICCInfo: Listener threw an error! ReferenceError: settings is not defined
E/GeckoConsole(  179): Content JS ERROR at app://system.gaiamobile.org/shared/js/operator_variant_helper.js:152 in OperatorVariantHelper.prototype.checkICCInfo: Listener threw an error! ReferenceError: settings is not defined
E/GeckoConsole(  694): Could not read chrome manifest 'file:///system/b2g/chrome.manifest'.
E/GeckoConsole(  179): Content JS ERROR at app://system.gaiamobile.org/shared/js/operator_variant_helper.js:152 in OperatorVariantHelper.prototype.checkICCInfo: Listener threw an error! ReferenceError: settings is not defined
E/GeckoConsole(  179): Content JS ERROR at app://system.gaiamobile.org/shared/js/operator_variant_helper.js:152 in OperatorVariantHelper.prototype.checkICCInfo: Listener threw an error! ReferenceError: settings is not defined
E/GeckoConsole(  179): Content JS ERROR at app://system.gaiamobile.org/shared/js/operator_variant_helper.js:152 in OperatorVariantHelper.prototype.checkICCInfo: Listener threw an error! ReferenceError: settings is not defined

Comment 1

[Aus Lacroix [:aus]]

Attachment: Patch - v1 - Bind context to listener used in operator variant APN customizer

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Operator Variant APN Customizer
[User impact] if declined: Fails to apply appropriate APN settings for Data/SUPL/Cell Broadcast
[Testing completed]: B2G Desktop, Gaia Unit Tests. Needs Testing on Nexus 4.
[Risk to taking this patch] (and alternatives if risky): Little to no risk.
[String changes made]: None.

Comment 2

[Aus Lacroix [:aus]]

Attachment: Patch - v2 - Bind context to listener. Use mozSettings directly.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Operator Variant APN Customizer
[User impact] if declined: Fails to apply appropriate APN settings for Data/SUPL/Cell Broadcast
[Testing completed]: B2G Desktop, Gaia Unit Tests. Needs Testing on Nexus 4.
[Risk to taking this patch] (and alternatives if risky): Little to no risk.
[String changes made]: None.

Comment 3

[Aus Lacroix [:aus]]

Comment on attachment 808029 [details]
Patch - v2 - Bind context to listener. Use mozSettings directly.

Updated Pull Request.

Comment 4

[Aus Lacroix [:aus]]

Gregor, if you have time to re-test with the new changes that'd be much appreciated. I want to make sure it resolves the issues for you on your test hardware. It *does* fix it on my Peak as expected.

Comment 5

[Aus Lacroix [:aus]]

Confirmed as working on Nexus 4 (which was the device this issue was reported on initially).

Comment 6

[Gregor Wagner [:gwagner]]

2219d5597ce1d6187420f8c26785030b876f2969

Comment 7

[James Lal [:lightsofapollo]]

Uplifted 2219d5597ce1d6187420f8c26785030b876f2969 to:
v1.2: df61e8d1c224b127b2f79f85f5d7ddf489cad879