Support Contacts variant values don't display if support.json file from market customizations doesn't exist/isn't updated

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: qdot, Assigned: aus)

Tracking

unspecified
x86_64
Linux

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 verified)

Details

(Whiteboard: [systemsfe], QARegressExclude)

Attachments

(1 attachment)

As of the landing of bug 891724, support contacts are customized if a variant setting exists that matches the SIMs mnc/mcc pair. However, if whoever is shipping the OS didn't include the support.json file from market customizations, or else didn't edit it to be anything more than the default "null", we'll never actually print out support contact settings loaded from operator variant files.
Summary: Support Contacts variant customization doesn't update if no support.json file exists from market customizations → Support Contacts variant values don't display if support.json file from market customizations doesn't exist/isn't updated

Updated

5 years ago
Whiteboard: [systemsfe]
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Assignee: nobody → aus
(Assignee)

Comment 1

5 years ago
Created attachment 808031 [details]
Patch - v1 - Attempt to use support contact values from Settings DB first, fall back to support.json contents if present.

I've tested this and it seems to work but there's something funky going on when opening the link in the browser. It's like the href value isn't present but it's being set as expected. I'm a little confused about how to debug this issue.
Attachment #808031 - Flags: review?(kyle)
(Assignee)

Comment 2

5 years ago
I should add that nothing weird is thrown in the error console when the link fails to open as expected in the browser.
(Assignee)

Comment 3

5 years ago
Master: https://github.com/mozilla-b2g/gaia/commit/82e40d19de1a9fdc754e8c7d3806f5ce9a078743
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-b2g-v1.2: --- → affected
Resolution: --- → FIXED

Updated

5 years ago
Blocks: 891724
Keywords: verifyme

Updated

5 years ago
blocking-b2g: koi? → koi+
Uplifted 82e40d19de1a9fdc754e8c7d3806f5ce9a078743 to:
v1.2: 71b76c0b59e7a4bdee450919b47d2d486bd6a981
status-b2g-v1.2: affected → fixed

Updated

5 years ago
Whiteboard: [systemsfe] → [systemsfe], QARegressExclude

Updated

5 years ago
QA Contact: jsmith
Verified on 1.2 by testing that a variant customization for support contacts works if no default support contacts customization was included.
status-b2g-v1.2: fixed → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.