Closed
Bug 918602
Opened 11 years ago
Closed 11 years ago
Give keyboard keys a role of "key"
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
|
1.39 KB,
patch
|
djf
:
review+
|
Details | Diff | Splinter Review |
This is a special role that is meant to make it easier for assistive technologies to enter text and numbers.
|
Assignee | |
Comment 1•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/12325
Attachment #807548 -
Flags: review?(dflanagan)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 807548 [details] [diff] [review] Give keyboard keys 'key' role. This is great! Thank you. r+
Attachment #807548 -
Flags: review?(dflanagan) → review+
|
||
Updated•11 years ago
|
Assignee: nobody → eitan
|
|
Assignee | |
Comment 3•11 years ago
|
||
Sorry, David. I got feedback from Marco about this. It looks like return and backspace keys should remain buttons. This keeps users safer from deleting text, or sending messages by mistake. So hopefully you will find this patch, just as great :)
Attachment #807548 -
Attachment is obsolete: true
Attachment #808788 -
Flags: review?(dflanagan)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 808788 [details] [diff] [review] Give keyboard keys 'key' role. Review of attachment 808788 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Eitan! Thanks Marco!
Attachment #808788 -
Flags: review?(dflanagan) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/41a5677869969cb94b14e6c7a1aa7702c087e8a7 Thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•