918624 - [Buri][fugu][Camera][Gallery]Re-entering the Camera can't return to video mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Description

[sync-1]

Firefox os  v1.1
  Mozilla build ID:20130916041201
 
 Created an attachment (id=520563)
 video
 
 DEFECT DESCRIPTION:
 Re-entering the Camera can't return to video mode
 
 REPRODUCING PROCEDURES:
 1.Launch Camera app,switch to video mode,record a video
 2.Click gallery icon in the bottom of left,entering Gallery
 3.Click camera icon in the bottom of left,return to Camera-->can't return to video mode-->ko
 
 Note1:Steps 1,2,3 again,it will be return to video mode
 
 Note2:The following steps can also appear this issue
       1.Launch Camera app,switch to video mode,record a video
       2.Click power key Lock the screen
       3.Re-entering the Camera from lock screen-->can't return to video mode-->ko
  
 EXPECTED BEHAVIOUR:
 ko:Re-entering the Camera it will be return to video mode
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 Mid
 
 REPRODUCING RATE:
 5/5

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: video

Comment 3

[liangxin]

In the Camra App,the variable _captureMode record camera/video mode,not the avriable activity.source.data.type.So we should determine camera/video mode by _captureMode but not variable types in HandleActivity function.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

liangxin, 

I had looked this bug, today. Your clue is correct. The camera mode is changed while handling activity. But the assumption may not be correct. We should use activity.source.data.type to determine the camera mode. But the gallery app should not only supply "photos" in activity[1]. It should put "photos" and "videos" both. In the activity handling of camera app, we also need to handle this case. It looks too simple to handle it currently[2].

[1] https://github.com/mozilla-b2g/gaia/blob/8581607807b97e2f0f02b7dae839bd4ab21ecf07/apps/gallery/js/gallery.js#L918-L923
[2] https://github.com/mozilla-b2g/gaia/blob/8581607807b97e2f0f02b7dae839bd4ab21ecf07/apps/camera/js/camera.js#L413-L415

Comment 5

[Diego Marcos [:dmarcos]]

This doesn't reproduce on 1.4 / 2.0 / master. Please reopen if this reoccurs.