918652 - "Serial execution error defering ..." with pymake with MOZ_PSEUDO_DERECURSE

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

When building with MOZ_PSEUDO_DERECURSE, python chokes on this assertion:
http://hg.mozilla.org/mozilla-central/file/59beb1868522/build/pymake/pymake/process.py#l464

This may or may not be related to the fact that it does "Entering directory blah" for a lot more directories than there are processes number given to -j.

Interestingly, removing the assert seems to build properly. As I have not researched how this code works, I can't say whether it's safe of not.

Comment 2

[Mike Hommey [:glandium]]

I'm now getting this other assertion with pymake on windows:

Traceback (most recent call last):
  File "build/pymake/make.py", line 30, in <module>
    pymake.process.ParallelContext.spin()
  File "c:\Users\mh\mozilla-central\build\pymake\pymake\process.py", line 531, in spin
    assert any(len(c.pending) for c in ParallelContext._allcontexts)
AssertionError

Removing it ends up in a deadlock.

Comment 3

[Mike Hommey [:glandium]]

And this assertion with -j1:

Traceback (most recent call last):
  File "build/pymake/make.py", line 30, in <module>
    pymake.process.ParallelContext.spin()
  File "c:\Users\mh\mozilla-central\build\pymake\pymake\process.py", line 523, in spin
    c.run()
  File "c:\Users\mh\mozilla-central\build\pymake\pymake\process.py", line 453, in run
    cb(*args, **kwargs)
  File "c:\Users\mh\mozilla-central\build\pymake\pymake\data.py", line 1266, in make
    assert not serial
AssertionError

Comment 4

[Chris Cooper [:coop] (he/him)]

Mass close of pymake-related bugs.