Closed
Bug 918701
Opened 12 years ago
Closed 12 years ago
Gaia.json auto-commit script should use a=gaia-bump not a=NPOTB since it is part of the build
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
|
1.28 KB,
patch
|
mozilla
:
review+
|
Details | Diff | Splinter Review |
(In reply to Ed Morley [:edmorley UTC+1] from bug 915596 comment #11)
> Comment on attachment 806756 [details] [diff] [review]
> approval
>
> Review of attachment 806756 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: scripts/bump_gaia_json.py
> @@ +107,5 @@
> > changeset_config['node'][:12],
> > changeset_config['author'],
> > changeset_config['desc'],
> > )
> > + message = 'Bumping gaia.json for %d %s revision(s) a=NPOTB\n' % (
>
> Please can we change this? It is indeed part of the build, so something like
> a=gaia-sync would be more accurate... :-)
|
Assignee | |
Updated•12 years ago
|
Summary: Gaia.json auto-commit script should use a=gaia-sync not a=NPOTB since it is part of the build → Gaia.json auto-commit script should use a=gaia-bump not a=NPOTB since it is part of the build
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #807665 -
Flags: review?(aki)
|
||
Updated•12 years ago
|
Attachment #807665 -
Flags: review?(aki) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
||
Comment 3•12 years ago
|
||
Looks fixed.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: Release Engineering → Developer Services
You need to log in
before you can comment on or make changes to this bug.
Description
•