918765 - nsIConsoleListener should be labelled [function]

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

STR
1. Service.console.addListener(function() { ... });
2. Wonder why the listener is never called.

Steps to Fix:
add label [function] to nsIConsoleListener.idl

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Labelling nsIConsoleListener with [function]

Attaching my shortest patch ever.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 807696 [details] [diff] [review]
Labelling nsIConsoleListener with [function]

Review of attachment 807696 [details] [diff] [review]:
-----------------------------------------------------------------

do that, and r+

::: xpcom/base/nsIConsoleListener.idl
@@ +14,1 @@
>  interface nsIConsoleListener : nsISupports

why didn't you bump the uuid?

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Attachment: Labelling nsIConsoleListener with [function], v2

I didn't change it because it affected neither providers nor consumers. But yes, you are right, I should have.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/bcf0a8ffb8e8

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bcf0a8ffb8e8