Closed Bug 918773 Opened 8 years ago Closed 5 years ago

[XHR2] responseXML.referrer is set, expected empty string

Categories

(Core :: DOM: Core & HTML, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: hsteen, Assigned: wisniewskit)

References

()

Details

Attachments

(1 file, 3 obsolete files)

This patch fixes the referrer and lastModified attributes of responseXML for the tests, covering two of the four failing cases in the WPT. Bug 918768 is about the remaining document.cookie issues, so I'll leave those changes for that bug.

Try shows no failures: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bab3c914c5a2

Note that the existing web platform test does not actually get a Last-Modified HTTP header with the response, so the Last-Modified test will never pass as-is. As such the test will have to be corrected upstream before this patch lands, or I'll have to tweak it to still expect a failure from that test for now. I'll attach a second patch with a version of the test that works.
Attachment #8762990 - Flags: review?(jonas)
Whoops, sorry, that first comment has the WPT-fixing patch, not the one that helps Firefox pass the tests. This is the one to review.
Attachment #8762991 - Flags: review?(jonas)
Attachment #8762990 - Flags: review?(jonas)
Anne, could you take a peek at my comments and patch in comment 1 in this bug? Thanks!
Flags: needinfo?(annevk)
This looks wrong. According to https://html.spec.whatwg.org/multipage/dom.html#dom-document-lastmodified even if that header is not present, document.lastModified still returns a value. It seems Chrome fails this too however so maybe we should change what this property returns for documents that are not the result of a navigation?
Flags: needinfo?(annevk)
Alright, here's a patch with just the responseXML.referrer changes.

I've created bug 1280454 to deal with lastModified once a decision is made on what to do there.
Attachment #8762990 - Attachment is obsolete: true
Attachment #8762991 - Attachment is obsolete: true
Attachment #8762991 - Flags: review?(jonas)
Attachment #8763093 - Flags: review?(jonas)
Rebased.
Attachment #8763093 - Attachment is obsolete: true
Attachment #8763093 - Flags: review?(jonas)
Attachment #8766864 - Flags: review?(jst)
Attachment #8766864 - Flags: review?(jst) → review+
Assignee: nobody → wisniewskit
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f85f05c1e20
set responseXML.referrer to the empty string. r=jst
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3f85f05c1e20
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.