91880 - Radio focus handling not quite correct

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[[e-mail]]

Using Build ID: 2001072003

Steps to reproduce problem:
1. Edit/Preferences
2. Advanced/Mouse Wheel
3. Focus on the Use System Default checkbox
Actual Result: Both checkbox and radio button get focus

Expected result: Only checkbox gets focus.

Comment 1

[[e-mail]]

Attachment: Patch to fix problem by limiting focus effect to radiogroup

Comment 2

[John Morrison]

-> blake (kick back if that is wrong, Blake).

Comment 3

[Håkan Waara]

Good work Neil; r=hwaara.

Comment 4

[Håkan Waara]

CC hyatt for super-review of the XBL.

Comment 5

[Blake Ross]

Checked in. Note that right clicking on a child of a radiobutton in a radiogroup
still focuses the radiobutton.  For example, this means that selecting the
Manual Proxy Configuration radiobutton in the Advanced > Proxies pref panel and
then right clicking on one of the textboxes will focus the radiobutton, and thus
the items in the context menu won't enable/disable/function properly.  There's a
separate bug on that.

Comment 6

[[e-mail]]

Blake: I couldn't find the bug which you are referring to, but it only seems to
affect the textbox context menu, rather than any right click in particular. It
also depends on the radiogroup being able to take focus, so if you remove the
focus rule from xul.css or disable the radiogroup then the context menu works.