918819 - Fix bustage from Bug 917295 (GC: Handlify public date APIs)

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Philip Chee]

Error message while building:

c:/t1/hg/comm-central/calendar/base/backend/libical/calDateTime.cpp(625) : error C2664: 'JS_ObjectIsDate' : cannot convert parameter 2 from 'JSObject *' to 'JS::HandleObject'
No constructor could take the source type, or constructor overload resolution was ambiguous

Comment 1

[Philip Chee]

Attachment: Patch v1.0 first attempt to fix bustage.

Comment 2

[Philip Chee]

Comment on attachment 807750 [details] [diff] [review]
Patch v1.0 first attempt to fix bustage.

I have no idea what I'm doing so I'll CC the person who worked on Bug 917295

Comment 3

[Jon Coppeard (:jonco)]

Comment on attachment 807750 [details] [diff] [review]
Patch v1.0 first attempt to fix bustage.

Review of attachment 807750 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine.

Comment 4

[Philip Chee]

Pushed bustage fix to comm-central
Leaving open for ex post facto review from Lightning peer.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 807750 [details] [diff] [review]
Patch v1.0 first attempt to fix bustage.

Thanks for the patch and review! I would have been fine with only one review, but the code looks fine. r=philipp

Comment 6

[Philip Chee]

Oops forgot to link to the pushed changeset:
https://hg.mozilla.org/comm-central/rev/a5925d4f1670