918839 - Apply Bug 873937 to master

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

+++ This bug was initially created as a clone of Bug #873937 +++

Bug 873937 fixed a problem of the texture rendering from 9px to 16px height on Adreno (TM) 200. When the bug was created a patch in Bug 884188 covered the fix. But right now, the patch in Bug 884188 does not cover the fix. It is necessary to apply the change to master and b2gv1.2

The problem could be confirmed by using the following url.
  http://people.mozilla.org/~sikeda/test_input_height.html

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - extend ThebesLayerBuffer's height to more than 32

Confirmed the patch works on master hamachi by disabling HwComposer.

Comment 2

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=56d353cf3c61

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - extend ThebesLayerBuffer's height to more than 32

Committable patch. Carry "jmuizelaar: review+".

Comment 4

[Gabriele Svelto [:gsvelto]]

(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> Confirmed the patch works on master hamachi by disabling HwComposer.

If that's the case then this is not really a fix: in bug 884188 we wanted to have the HwComposer active while painting the network activity icon but this requires having gralloc'd surfaces of at least 17 pixels (and increasing the network icon to that size). If I understand this patch correctly this disables hardware composition for anything below 32 pixels... or am I misunderstanding how it works?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/02833b048b90

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to Gabriele Svelto [:gsvelto] from comment #4)
> (In reply to Sotaro Ikeda [:sotaro] from comment #1)
> > Confirmed the patch works on master hamachi by disabling HwComposer.
> 
> If that's the case then this is not really a fix: in bug 884188 we wanted to
> have the HwComposer active while painting the network activity icon but this
> requires having gralloc'd surfaces of at least 17 pixels (and increasing the
> network icon to that size). If I understand this patch correctly this
> disables hardware composition for anything below 32 pixels... or am I
> misunderstanding how it works?

The patch does not disable the HwComposer, just extend the thebes buffer's height to more than 32. This bug happens only on OpenGL rendering. Therefore to confirm the fix, I disabled HwComposer temporarily on my built ROM.

Comment 7

[Gabriele Svelto [:gsvelto]]

(In reply to Sotaro Ikeda [:sotaro] from comment #6)
> The patch does not disable the HwComposer, just extend the thebes buffer's
> height to more than 32. This bug happens only on OpenGL rendering. Therefore
> to confirm the fix, I disabled HwComposer temporarily on my built ROM.

Thank you for clearing this up for me :-)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/02833b048b90

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4cb0a48b7574