918853 - Existing Thunderbird profile is no longer offered for import in a first-run situation

Status: VERIFIED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[rsx11m]

Steps to reproduce:

 1. Make sure to have a Thunderbird profile folder in AppData (Windows)
    or ~/.thunderbird (Linux)

 2. Rename the Mozilla (~/.mozilla) folder to trigger first-run situation

 3. Start SeaMonkey

Expected behavior:

 4. Import Wizard shows up, offering import of the Thunderbird profile

Actual behavior:

 4. Browser with start page shows up directly without the Import Wizard
    being invoked

This regression was introduced some time during the 2.23a1 cycle.

Comment 1

[rsx11m]

Actually, quite early into the previous cycle:

  Last working 2.23a1 build: 2013-08-06
  First broken 2.23a1 build: 2013-08-07

http://hg.mozilla.org/comm-central/pushloghtml?startdate=2013-08-06&enddate=2013-08-07

Bug 739056 - "Port |Bug 715099 - Convert nsProfileMigrator to JS so we can use JS modules on migration| to SeaMonkey" looks like a matching candidate for this regression?

Comment 2

[Edmund Wong (:ewong)]

(In reply to rsx11m from comment #1)
> Actually, quite early into the previous cycle:
> 
>   Last working 2.23a1 build: 2013-08-06
>   First broken 2.23a1 build: 2013-08-07
> 
> http://hg.mozilla.org/comm-central/pushloghtml?startdate=2013-08-
> 06&enddate=2013-08-07
> 
> Bug 739056 - "Port |Bug 715099 - Convert nsProfileMigrator to JS so we can
> use JS modules on migration| to SeaMonkey" looks like a matching candidate
> for this regression?

Probably.  I'm looking into this.  I just need to build a recent tree.

Comment 3

[rsx11m]

Thanks (and there is a typo in the bug summary, correcting that).

Comment 4

[Philip Chee]

Firefox migrator Bug 715099 had the same problem. One of the dependencies of that bug is:
Bug 724808 (First run import wizard doesn't show up on Firefox 12 and 13). Ewong just needs to port https://hg.mozilla.org/mozilla-central/rev/f0cc27e3731c

Comment 5

[Edmund Wong (:ewong)]

Attachment: Proposed patch (v1)

Comment 6

[Philip Chee]

Comment on attachment 810911 [details] [diff] [review]
Proposed patch (v1)

Frank probably has more time to do reviews. r? => mcsmurf

Comment 7

[Frank Wein [:mcsmurf]]

Comment on attachment 810911 [details] [diff] [review]
Proposed patch (v1)

Yeah, looks good. Remember to land this on aurora as well.

Comment 8

[Philip Chee]

Comment on attachment 810911 [details] [diff] [review]
Proposed patch (v1)

[Approval Request Comment]
Regression caused by (bug #): Bug 739056
User impact if declined:  Existing Thunderbird profile is no longer offered for import in a first-run situation
Testing completed (on m-c, etc.): working on CC 
Risk to taking this patch (and alternatives if risky): Low to none (buildconfig change)
String changes made by this patch: None.

Comment 9

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/f62a973749f7
Pushed to comm-aurora:
http://hg.mozilla.org/releases/comm-aurora/rev/ddb6e3745674

Comment 10

[rsx11m]

Verified fixed Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 SeaMonkey/2.23a2
Build identifier: 20131019013001.