As discussed with Kadir on Skype earlier today we've decided to switch from our current locally stored avatars to gravatars. This will allow us to:
- Worry less about dealing with image uploads
- Let gravatar do the heavy lifting for delivering the correct image size
- Pull existing gravatars for user that may not have sumo avatars and hopefully have less default/no-avatar avatars.
As part of the implementation we will be:
- Pulling the gravatar by email
- If no gravatar exists we use the local avatar as the fallback
- When a user goes to edit their profile they will be directed to gravatar.com to update their avatar.
Their may be some initial friction for a few users who may be unfamiliar with gravatars, but for the most part I think this will solve a lot of problems and be a pretty smooth process.
pushing to next sprint.
I think this is a pretty involved change. We need to change the edit profile form, remove avatar upload handling from the UI and views, clean up all the avatars that have been uploaded, etc.
Pretty sure :rdalal is on this.
Kadir asked for this to be put on stage for a while before we go live, so adding the [needsverify] tag to the whiteboard.
Pushed to stage for verification.
Hey Rehan, thanks for thins change. Looks really good.
One confusing thing though:
When I add an image on Gravatar, I'm still on the "edit profile" page on SUMO. The changes on Gravatar are not reflected on SUMO though. That is pretty confusing. I didn't know what to do to have the change reflected on SUMO.
We could either let people know that they have to reload the page when they have added an avatar or reload the page periodically (bad). It would be best of course if there was a way to detect that change on Gravatar. Not sure if their API allows for that though.
In case there is no API call for that, I'd say: let's show a message below the image on the "Edit profile" page that says: "It can take a few minutes for the avatar change to take effect. Please reload this page to see the new avatar."
Madalina, what's your take on this?
So the Gravatar can take a couple of minutes to update, it has to propagate over their CDN. Adding that text somewhere would make sense I think.
Deployed to prod by rdalal.
I talked to Madalina and she is OK with what we did. YAY!
That suggests there's http/https mixed-content stuff going on.