Closed
Bug 918872
Opened 11 years ago
Closed 11 years ago
System screen should use full highlights
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(blocking-b2g:-)
RESOLVED
FIXED
blocking-b2g | - |
People
(Reporter: epang, Assigned: pivanov)
References
Details
(Whiteboard: visual design, visual-tracking, jian)
Attachments
(3 files)
Hi Pavel, I missed one of the screens. When you press the power screen a list of options appears. This screen should use full length highlights as well. Thanks!
Assignee | ||
Comment 1•11 years ago
|
||
Hey Eric, the active state is the same as we talk for bug 917857
Attachment #808278 -
Flags: feedback?(epang)
Assignee | ||
Comment 2•11 years ago
|
||
Reporter | ||
Comment 3•11 years ago
|
||
Comment on attachment 808278 [details]
After patch screenshot
Looks good, thanks Pavel!
Attachment #808278 -
Flags: feedback?(epang) → feedback+
Assignee | ||
Updated•11 years ago
|
Attachment #808281 -
Flags: review?(sjochimek)
Reporter | ||
Comment 4•11 years ago
|
||
Sam, can you review so we can land? Thanks!
Flags: needinfo?(sjochimek)
Comment 5•11 years ago
|
||
Comment on attachment 808281 [details] patch for Gaia/master Landed on master: https://github.com/mozilla-b2g/gaia/commit/b2b3eafa16dedd16874825d8e13f4188e73830de
Attachment #808281 -
Flags: review?(sjochimek) → review+
Updated•11 years ago
|
Flags: needinfo?(sjochimek)
Reporter | ||
Comment 6•11 years ago
|
||
(In reply to Sam Joch [:samjoch] from comment #5) > Comment on attachment 808281 [details] > patch for Gaia/master > > Landed on master: > https://github.com/mozilla-b2g/gaia/commit/ > b2b3eafa16dedd16874825d8e13f4188e73830de Pavel, can you mark this as resolved fixed? Thanks!
Flags: needinfo?(pivanov)
Reporter | ||
Comment 7•11 years ago
|
||
Flagging as 1.3? since the highlight state currently looks broken.
blocking-b2g: --- → 1.3?
Whiteboard: visual design, visual-tracking → visual design, visual-tracking, jian
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(pivanov)
Resolution: --- → FIXED
Comment 8•11 years ago
|
||
not a regression from a past release, so this is not a blocker
blocking-b2g: 1.3? → -
You need to log in
before you can comment on or make changes to this bug.
Description
•