918956 - Add mox-server for offline emulated S3

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Pomax]

webmaker.org already uses noxmox for its events system, but doesn't yet try to fire up the mox-server to allow emulated content to also be served up.

See https://bugzilla.mozilla.org/show_bug.cgi?id=898463 for additional details.

Comment 1

[Pomax]

Attachment: https://github.com/mozilla/webmaker.org/pull/405

this is a tweak for s3.js so that in mox-mode it retrieves mox-stored files (currently only thumbnails) through mox-server, rather than through a relative path URL on webmaker.org, similar to how an S3 url would normaly have to be used.

Comment 2

[Pomax]

I know this works localhost under mox, but this definitely requires a test with real S3 creds to see if proper S3 publishing of an event still works (it should, but we want to be sure =D)

Comment 3

[Pomax]

leading slash locations:

1. https://github.com/mozilla/goggles.webmaker.org/blob/master/lib/middleware.js#L264
2. https://github.com/mozilla/thimble.webmaker.org/blob/master/lib/middleware.js#L248
3. https://github.com/mozilla/popcorn.webmaker.org/blob/master/lib/utilities.js#L21
4. https://github.com/Pomax/webmaker.org/blob/bug918956/lib/events/lib/s3.js#L24 [in review]

Comment 4

[Pomax]

ignore comment 3, wrong ticket, and no 'delete comment' option =_=

Comment 5

[inactivate account for kate]

Comment on attachment 812782 [details] [review]
https://github.com/mozilla/webmaker.org/pull/405

Code looks mostly good ( a couple of questions ).

This works fine except in the following case:
1. Make sure S3_EMULATION is not set at all in .env
2. Try to create an event with a thumbnail
3. This error happens http://pastebin.mozilla.org/3272389

Mind looking over that quickly, then this is good to land?

Comment 6

[Pomax]

able to replicate - oddly enough that's not an error according to the node console, and the web console doesn't show any output, suggesting the submission process stalls. Looking into where and why.

Comment 7

[Pomax]

Comment on attachment 812782 [details] [review]
https://github.com/mozilla/webmaker.org/pull/405

with correct S3 creds, this patch appears to work just fine with real S3. However, we're missing error handling routes for when S3 signals wrong credentials or other errors, which is why it looked like things weren't working. Filing a new bug specific for adding error handling code paths.

Comment 8

[Pomax]

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=927536 as followup for fixing the error handling.

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/cc0950eb39114b3f2f29bd5f6bb0c78815ebcba4
Merge pull request #405 from Pomax/bug918956

mox-server support for mox-stored event thumbnails

Comment 10

[Pomax]

merged, following up with https://bugzilla.mozilla.org/show_bug.cgi?id=922860 to get rid of that leading slash and add a mox-server version