918977 - remove invalid "dialog" css rules from TB themes

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[:aceman]

These CSS rules are found in Thunderbird theme files:
linux/mail/accountCreation.css:  background-color: dialog;
osx/mail/compose/messengercompose.css:  -moz-appearance: dialog;
osx/mail/compose/messengercompose.css:  -moz-appearance: dialog;

These are supposedly invalid per:
https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#System_Colors
https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-appearance

Maybe they just need update to the proper '*dialog*' keyword.
Until then, they are causing a CSS warning output in the Error console. E.g. the first one can be seen when entering New mail account wizard.

Comment 1

[Josiah Bruner [:jsbruner]]

Attachment: Fix.

Done. :)

Comment 2

[:aceman]

There is no "-moz-dialog" value on the -moz-appearance page...

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 807955 [details] [diff] [review]
Fix.

(In reply to :aceman from comment #2)
> There is no "-moz-dialog" value on the -moz-appearance page...

Correct, I cancelled the review request waiting for a new patch.

I tried removing both -moz-appearance and saw no difference. Josiah, please can you test this without the -moz-appearance and make a new patch?

Comment 4

[Josiah Bruner [:jsbruner]]

Attachment: Fix

So although the -moz prefix apparently silences the error when used with -moz-appearance, it doesn't do anything.

Turns out we do need the styling though, so I switched to background-color: -moz-dialog there as well.

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 808002 [details] [diff] [review]
Fix

Review of attachment 808002 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Thank you, Josiah.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/ec19b2b1da85

Comment 7

[Stefan [:stefanh]]

JFTR (and you can't rely on official documentation here):

1) "moz-dialog" is a color: see for example http://mxr.mozilla.org/mozilla-central/source/widget/cocoa/nsLookAndFeel.mm#222

2) -moz-appearance: dialog is valid. But it's just a background anyway. See http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSProps.cpp#596 and http://mxr.mozilla.org/mozilla-central/source/widget/cocoa/nsNativeThemeCocoa.mm#2004 (I don't think it works on windows, though)