Closed Bug 918982 Opened 11 years ago Closed 10 years ago

FILE_NOT_FOUND error fired in logcat looking for singleVariant configuration file (singlevariantconf.json)

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jsmith, Assigned: albert)

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
crdlc
: review+
Details | Review
Seeing this in the logcat during daily testing of my Buri 1.2 9/20 build:

09-20 13:16:19.289: E/GeckoConsole(4734): Content JS ERROR at app://homescreen.gaiamobile.org/gaia_build_defer_index.js:365 in loadSVConfFileError: Failed parsing singleVariant configuration file [js/singlevariantconf.json]: [Exception... "File error: Not found"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: app://homescreen.gaiamobile.org/gaia_build_defer_index.js :: loadFile :: line 358"  data: no]

We should probably fail a bit more gracefully then just hit a unchecked exception. Probably related to the SIM customization work done.
Whiteboard: [systemsfe]
Hi Jason, I believe that code was written by the folks at TEF. I'm trying to dig through the commits to see which one contained these changes. I believe this is, however, a blocking issue since it is likely that folks will be shipping builds *without* a customization file for the homescreen apps and we probably don't want to throw exceptions for missing files.
Assignee: nobody → alberto.crespellperez
Attached file Patch
Attachment #8475849 - Flags: review?(crdlc)
That message is just to inform, is ok to you changing the console.error by console.log? Or do you want to remove it completely?
Flags: needinfo?(jsmith)
Comment on attachment 8475849 [details] [review]
Patch

Good job, thanks
Attachment #8475849 - Flags: review?(crdlc) → review+
(In reply to Albert [:albert] from comment #3)
> That message is just to inform, is ok to you changing the console.error by
> console.log? Or do you want to remove it completely?

Using console.log works for me.
Flags: needinfo?(jsmith)
Master https://github.com/mozilla-b2g/gaia/commit/3a7e6277dde31e5a3b9b3861bcf50f105a4669c0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: