Closed Bug 918991 Opened 6 years ago Closed 6 years ago

Convert controls.css to LESS

Categories

(Webmaker Graveyard :: Popcorn Maker, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mjschranz, Assigned: gioyik)

Details

(Whiteboard: [mentor=thecount][mentor=mjschranz][good first bug])

Attachments

(1 file)

This is mostly to help keep maintaining any changes here easier because we can then tie it into our LESS globals.
Whiteboard: [mentor=thecount][mentor=mjschranz]
Whiteboard: [mentor=thecount][mentor=mjschranz] → [mentor=thecount][mentor=mjschranz][good first bug]
Hi,

I am interested in this bug. Could you give me more info about where is located the file to convert and where to push the changes?

Regards,
Gio
Hi Gio, thanks for taking on this bug!

The repository that you'll be working with is https://github.com/mozilla/popcorn.webmaker.org . Within that repository, you'll be converting https://github.com/mozilla/popcorn.webmaker.org/blob/master/public/css/controls.css to be a .less file ( http://lesscss.org/ ) instead of a .css file.
Assignee: nobody → gioyik
Status: NEW → ASSIGNED
Hi Jon,

The controls.css needs to be removed from the repo or keep it there?
It'll need to be removed, yes. When a LESS file is compiled, it outputs a CSS file in the same directory
Attachment #8340953 - Flags: review?(scott)
Hi Jon and Matthew,

I made a Pull Request on Github, could you check it and tell me if is what you need for this bug?

Regards,
Gio
Comment on attachment 8340953 [details] [review]
Convertion from css to less

Yup, works well. This is what we want.
Attachment #8340953 - Flags: review?(scott) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.