Closed
Bug 918991
Opened 11 years ago
Closed 11 years ago
Convert controls.css to LESS
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mjschranz, Assigned: gioyik)
Details
(Whiteboard: [mentor=thecount][mentor=mjschranz][good first bug])
Attachments
(1 file)
This is mostly to help keep maintaining any changes here easier because we can then tie it into our LESS globals.
Updated•11 years ago
|
Whiteboard: [mentor=thecount][mentor=mjschranz]
Reporter | ||
Updated•11 years ago
|
Whiteboard: [mentor=thecount][mentor=mjschranz] → [mentor=thecount][mentor=mjschranz][good first bug]
Assignee | ||
Comment 1•11 years ago
|
||
Hi, I am interested in this bug. Could you give me more info about where is located the file to convert and where to push the changes? Regards, Gio
Comment 2•11 years ago
|
||
Hi Gio, thanks for taking on this bug! The repository that you'll be working with is https://github.com/mozilla/popcorn.webmaker.org . Within that repository, you'll be converting https://github.com/mozilla/popcorn.webmaker.org/blob/master/public/css/controls.css to be a .less file ( http://lesscss.org/ ) instead of a .css file.
Assignee: nobody → gioyik
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•11 years ago
|
||
Hi Jon, The controls.css needs to be removed from the repo or keep it there?
Comment 4•11 years ago
|
||
It'll need to be removed, yes. When a LESS file is compiled, it outputs a CSS file in the same directory
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #8340953 -
Flags: review?(scott)
Assignee | ||
Comment 6•11 years ago
|
||
Hi Jon and Matthew, I made a Pull Request on Github, could you check it and tell me if is what you need for this bug? Regards, Gio
Comment 7•11 years ago
|
||
Comment on attachment 8340953 [details] [review] Convertion from css to less Yup, works well. This is what we want.
Attachment #8340953 -
Flags: review?(scott) → review+
Comment 8•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/b3a08deb58f3bb66d2f98386d88b1464ad928396 Fix Bug 918991 - Convert controls.css to LESS
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•