Closed
Bug 918998
Opened 11 years ago
Closed 11 years ago
[1.2][email] Grouped notifications should not show email address when only one email account is configured.
Categories
(Firefox OS Graveyard :: Gaia::E-Mail, defect)
Tracking
(blocking-b2g:koi+, b2g-v1.2 verified)
Tracking | Status | |
---|---|---|
b2g-v1.2 | --- | verified |
People
(Reporter: parul, Assigned: evanxd)
References
Details
(Keywords: late-l10n)
Attachments
(6 files, 2 obsolete files)
Test Environment: Device: Leo OS version: 1.2.0.0-prerelease Firmware revision: D300f10a Hardware revision: d300 Platform version: 26.0a2 Gecko: 0322470077b7 Build Identifier: 20130920004004 Update channel: leo/1.2.0/nightly Gaia: 2e88444c39998e0b90513ad9f8ab9413f3fe246f1379486243 Git commit info: 2013-09-20 02:00:38 Steps to reproduce: 1. Go to Settings > Display and set Screen timeout to 1 minute. 2. On the home screen, tap on the E-Mail icon to launch the email app. 3. Setup a new email account or ensure that one is already configured with the following options: A. Check for new messages: Every 5 minutes B. Display notifications for new messages: ON 4. Press the home button to send the email app in the background. 5. Allow the phone screen to time out through inactivity. 6. On a computer, sign in to the configured email account and arrange to receive several emails in it. (This can be done either by sending emails from another account or by subscribing to a high-volume mailing list.) Expected Results: After 5 minutes, the email app should sync with the mail server. The email app should generate a notification of new emails received on the phone lock screen as well as the Utility Tray in the following format: First line: Number of new emails in bold with "new emails" in lowercase, Relative time of email (e.g. "just now") Second line: Sender names on second line separated by commas in chronological order (oldest email first, newest last) with truncation For example: (see screenshot https://bug916516.bugzilla.mozilla.org/attachment.cgi?id=804975) 5 new emails Philipp Wagner, ISHIKAWA,chiaki, Reuben Morais, Robert O'Callahan, Anne van Kesteren Actual: First line: Number of new emails in bold with "New Emails" in camelcase, hyphen as separator, email address of account, Relative time of email (e.g. "just now") Second line: Sender names on second line separated by commas in chronological order (oldest first, newest last) with truncation For example: 5 new emails - abc@gmail.com Anne van Kesteren, Robert O'Callahan, Reuben Morais, ISHIKAWA,chiaki, Philipp Wagner Suggestion: Perhaps the 2 lines of notification could show more information related to the emails received once the email address of the account has been removed. (see screenshot attached)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → evanxd
Assignee | ||
Comment 2•11 years ago
|
||
Hi James, Could you give me feedback for the patch? Thanks. :)
Attachment #817841 -
Flags: feedback?(jrburke)
Comment 3•11 years ago
|
||
Comment on attachment 817841 [details] PR v1 Some feedback in the pull request, but this is on the right track. Since we need to change some strings, are you OK with also doing the changes mentioned for bug 919004#c5 ? That would fix the other bug, but then also means we just have the one ticket doing l10n changes to these notification strings. The l10n teams will appreciate it if we can do that.
Attachment #817841 -
Flags: feedback?(jrburke)
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 817841 [details]
PR v1
Hi James,
I updated the patch.
Please help me to review the patch.
Thanks. :)
Attachment #817841 -
Flags: review?(jrburke)
Comment 5•11 years ago
|
||
Comment on attachment 817841 [details] PR v1 Evan, I gave feedback in the pull request. I would like to see those changes done, then flip the r? back to me, and I will do a final review with test on phone. Looking good, just a bit more to align with UX desires in bug 919004.
Attachment #817841 -
Flags: review?(jrburke)
Assignee | ||
Comment 6•11 years ago
|
||
Assignee | ||
Comment 7•11 years ago
|
||
Assignee | ||
Comment 8•11 years ago
|
||
Assignee | ||
Comment 9•11 years ago
|
||
Assignee | ||
Comment 10•11 years ago
|
||
Attachment #818930 -
Attachment is obsolete: true
Assignee | ||
Comment 11•11 years ago
|
||
Comment on attachment 817841 [details] PR v1 Hi James, I updated the patch for your comments. We could see the screenshot for that patch: * One account and one message: attachment 818926 [details] * One account and multiple messages: attachment 818927 [details] * Multiple accounts and one message: attachment 818937 [details] * Multiple accounts and multiple messages: attachment 818931 [details] And please help me to review it. Thanks. :)
Attachment #817841 -
Flags: review?(jrburke)
Updated•11 years ago
|
Target Milestone: --- → 1.3 Sprint 3 - 10/25
Comment 12•11 years ago
|
||
Comment on attachment 817841 [details]
PR v1
Looks great, the screenshots really helped. I was able to get a UX r+ from :robmac in IRC by having the screenshots.
I had just a couple of small nits in this last review, and the last new l10n string needs some curly quotes in it. With those changes, r+ from me, and the pull request will be good to merge if the travis build for the pull request is green.
Attachment #817841 -
Flags: review?(jrburke) → review+
Assignee | ||
Comment 13•11 years ago
|
||
Attachment #818937 -
Attachment is obsolete: true
Assignee | ||
Comment 14•11 years ago
|
||
Hi James, I updated the patch. The travis build is not passed with gaia-ui-test for many times. But the changes of the patch seems be not related with the error part. I'm checking on that.
Comment 15•11 years ago
|
||
Evan, updated patch looks great, r+ still from me. If the failures were around the contacts tests, then I think those are fixed now in latest master (or at least turned off), so if you get latest master and rebase on top of that, it should pass travis. The run that is on that pull request is showing green though, at least according to the travis link on that pull request. So if latest rebase on latest master is good, I think this is good to merge!
Assignee | ||
Comment 16•11 years ago
|
||
Hi James, Yes, it is passed.
Assignee | ||
Comment 17•11 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/0bbb26644f47f9ad6680136a122b0289cb2e183e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 19•11 years ago
|
||
Hi James, Thanks.
Comment 20•11 years ago
|
||
Uplifted 0bbb26644f47f9ad6680136a122b0289cb2e183e to: v1.2: 4a4a90202ca17ec4446d0e2ec9ad238c14782850
status-b2g-v1.2:
--- → fixed
Comment 21•11 years ago
|
||
Verified Fixed: Grouped messages no longer show email addresses in notifications when only one email account is setup. Environmental Variables Device: Buri v1.2 COM RIL Build ID: 20131107004003 Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/26f1e160e696 Gaia: 590eb598aacf1e2136b2b6aca5c3124557a365ca Platform Version: 26.0 RIL Version: 01.01.00.019.281 Firmware Version: US_20131104
You need to log in
before you can comment on or make changes to this bug.
Description
•