919014 - Change markup of keypad to be in logical order

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Eitan Isaacson [:eeejay]]

When using a screen reader and going to the next item the keys are not sequential, instead they are 1,4,7,*,2,5,8,0,3,6,9,#

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Fix communications dialer

Comment 2

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/pull/12345

Comment 3

[Etienne Segonzac (:etienne)]

(In reply to Eitan Isaacson [:eeejay] from comment #2)
> https://github.com/mozilla-b2g/gaia/pull/12345

Congrats on the PR number :)

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 807975 [details] [diff] [review]
Fix communications dialer

Review of attachment 807975 [details] [diff] [review]:
-----------------------------------------------------------------

Sadly, this breaks the call screen keyboard :/
We probably just need to do the markup change in oncall.html too (we load the same css file in both cases).

Also (not proud of this) but apparently we also have a copy of this markup in apps/communications/dialer/test/unit/mock_dialer_index.html.
We probably won't keep this kind of giant duplicated DOM for unit tests in the long run, but in the meantime it would be nice to keep it up to date with the real markup.

Thanks!

Comment 5

[Eitan Isaacson [:eeejay]]

Attachment: Fix communications dialer

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Reorder keys in communications dialer

This fixes the oncall keypad as well as the test one. The css seems to just work!

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 808804 [details] [diff] [review]
Reorder keys in communications dialer

Review of attachment 808804 [details] [diff] [review]:
-----------------------------------------------------------------

All good, thank!

Comment 8

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/73d255717dadf6757064ac06cdbf60afe925520b

Thanks!