919069 - AccessibleMarshal.dll fails to build on VS2013 amd64_x86 cross-compile

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(Away)]

error LNK2001: unresolved external symbol _ISimpleDOMDocument_ProxyFileInfo
error LNK2001: unresolved external symbol _ISimpleDOMNode_ProxyFileInfo
error LNK2001: unresolved external symbol _ISimpleDOMText_ProxyFileInfo
AccessibleMarshal.dll : fatal error LNK1120: 3 unresolved externals

The MIDL-generated ISimpleDOMText_p.c and friends are getting wrapped in |#if defined(_M_AMD64)| so the entire file reduces to nothing on our 32-bit build.

I suspect we've got the wrong /env settings in http://dxr.mozilla.org/mozilla-central/source/configure.in#l505

Comment 1

[(Away)]

This is the version on my system:
Microsoft (R) 32b/64b MIDL Compiler Version 8.00.0603

Comment 2

[(Away)]

CC some people who were involved with Bug 471854 - Build error in accessible/public/msaa on x64 Windows with VC8

Do we really need the highly-specific version checks on MIDL? It seems like if the target is x86, then we always want |-env win32|, whether or not it's the default option. I guess the only concern might be if some older versions of MIDL didn't understand |-env|. Any thoughts?

Comment 3

[Masatoshi Kimura [:emk]]

Our minimum requirement is already VS2010, so older MIDL would not be a concern.

Comment 4

[(not currently active) Ted Mielczarek]

dmajor: that sounds sensible.

Comment 5

[(Away)]

Attachment: midl_env

Turns out nobody else was using the version variables so I just removed them. Too much?

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 808958 [details] [diff] [review]
midl_env

Review of attachment 808958 [details] [diff] [review]:
-----------------------------------------------------------------

Nope, removing unnecessary cruft is great.

::: configure.in
@@ +494,1 @@
>          AC_MSG_CHECKING([for midl flags])

I'd probably just drop the AC_MSG_{CHECKING,RESULT} while you're here too. It's not actually checking anything.

Comment 7

[(Away)]

Attachment: patch for checkin

patch for checkin -- removed AC comments as requested

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d10ded33e522

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d10ded33e522