Closed
Bug 919122
Opened 11 years ago
Closed 10 years ago
Support for SourceForge Allura bugs in "see also" field
Categories
(Bugzilla :: Creating/Changing Bugs, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 6.0
People
(Reporter: legoktm, Assigned: selsky)
References
Details
Attachments
(1 file, 4 obsolete files)
2.21 KB,
patch
|
gerv
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release) Build ID: 20130814063812 Steps to reproduce: Tried entering "https://sourceforge.net/p/pywikipediabot/feature-requests/349/" as a see also url. Actual results: It failed, because it is a new style url, instead of the old ones sf.net used to use. Expected results: It should have been accepted. Downstream bug report: https://bugzilla.wikimedia.org/show_bug.cgi?id=54416
Comment 1•11 years ago
|
||
Might be duped into bug 931355 :-/
Updated•10 years ago
|
Attachment #808092 -
Attachment is patch: true
Comment 3•10 years ago
|
||
Comment on attachment 808092 [details] [diff] [review] patch v1 Per https://bugzilla.wikimedia.org/show_bug.cgi?id=54416#c12, this regexp is too restrictive (- must be accepted and the URL can end with a /). @Kunal: would you agree to update your patch? And do not forget to request review. That's why your patch didn't appear in our radar.
Attachment #808092 -
Flags: review-
Updated•10 years ago
|
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
updated the patch to accept optional / at the end and accept - in the TYPE part of the URL
Assignee: create-and-change → aliustek
Attachment #808092 -
Attachment is obsolete: true
Attachment #8364600 -
Flags: review?(LpSolit)
Comment 5•10 years ago
|
||
Comment on attachment 8364600 [details] [diff] [review] sfBugURL.patch >+ and ($uri->path =~ m|^/p/[0-9a-zA-Z_]+/[0-9a-zA-Z_-]+/\d+/?$| This is not enough. It shouldn't let me pass any parameter with the URL.
Attachment #8364600 -
Flags: review?(LpSolit) → review-
Assignee | ||
Comment 6•10 years ago
|
||
Assignee: aliustek → selsky
Attachment #8364600 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8515741 -
Flags: review?(gerv)
Assignee | ||
Comment 7•10 years ago
|
||
Fixed nested of boolean logic
Attachment #8515741 -
Attachment is obsolete: true
Attachment #8515741 -
Flags: review?(gerv)
Attachment #8515745 -
Flags: review?(gerv)
Comment 8•10 years ago
|
||
Comment on attachment 8515745 [details] [diff] [review] v3 Hi Matt, Can you explain the change to _check_value? Is this operating on all See Also URLs, or only the Allura ones? Gerv
Assignee | ||
Comment 9•10 years ago
|
||
It's operating on all SF.net URLs, but it will only impact the Allura URLs that are entered without the trailing slash. I'm adding the trailing slash since that's the canonical form for Allura. The non-Allura form should do an exact match instead of a regex. Patch coming...
Assignee | ||
Comment 10•10 years ago
|
||
Attachment #8515745 -
Attachment is obsolete: true
Attachment #8515745 -
Flags: review?(gerv)
Attachment #8517254 -
Flags: review?(gerv)
Comment 11•10 years ago
|
||
Comment on attachment 8517254 [details] [diff] [review] v4 Review of attachment 8517254 [details] [diff] [review]: ----------------------------------------------------------------- r=gerv. Gerv
Attachment #8517254 -
Flags: review?(gerv) → review+
Assignee | ||
Updated•10 years ago
|
Flags: approval?
Comment 12•10 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git 82674d4..9e1efb5 master -> master Thanks for the patch, Matt! Gerv
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 13•10 years ago
|
||
Updated commit info for master: To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git 3afc1b7..34f2b77 master -> master Gerv
Comment 14•6 years ago
|
||
This patch should be backported to the 5.0 branch, because it's not possible to paste URLs using this new format without it.
You need to log in
before you can comment on or make changes to this bug.
Description
•