919158 - Clarify wording for plugin state

Status: VERIFIED FIXED

(Firefox Health Report Graveyard :: Web: Health Report, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

Open the Firefox/Nightly Health Report under 'Help'
Look at the plugin display at the bottom

Activated Plugins Enabled/Disabled shows incorrectly.

Its reverse of reality.

Tested with latest hourly m-c build on win7 x64
cset: https://hg.mozilla.org/mozilla-central/rev/a2c31dc69ab3

Not sure when Health Report page was updated as this seems to be fairly new.

Comment 2

[Alice0775 White]

This is caused by Bug 899080, and may be by design.

Comment 3

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to Alice0775 White from comment #2)
> This is caused by Bug 899080, and may be by design.

If its by design, then the section is mis-leading and should read perhaps:

Plugins enabled by CtoP or something...

Comment 4

[Benjamin Smedberg]

With click-to-play there are really three categories now, not two. Until we fix FHR to also record click-to-play plugins, they are recorded as disabled, which is roughly correct. For the time being I guess we could update the UI to be clearer about that. I'm not sure exactly how to word it though.

Comment 5

[Richard Newman [:rnewman]]

Perhaps as simple as changing the labels to

  enabled by default:       1
  not enabled by default:   8

as an interim step…?

Note that FHR does record click-to-play plugins:

        "{16ae005c-9049-fc46-14bd-5ee5bbac9bbf}": {
          "userDisabled": "askToActivate",
          "appDisabled": false,
          "version": "3.15.2.12038",
          "type": "plugin",
          "scope": 8,
          "foreignInstall": true,
          "installDay": 15764,
          "updateDay": 15764
        }

-- userDisabled can be true, false, or "askToActivate".

Shuffling this bug into Web, and setting [dev-doc-needed] with a pointer to gps to update the payload format spec.

Comment 6

[Benjamin Smedberg]

Attachment: Plugin summary shouldn't use "enabled" and "disabled" but should use the terms which match the addon manager UI

Comment 7

[Benjamin Smedberg]

Attachment: bug919158.patch

Comment 8

[Laura Thomson :laura]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #6)
> Created attachment 808664 [details] [diff] [review]
> Plugin summary shouldn't use "enabled" and "disabled" but should use the
> terms which match the addon manager UI

r+ for this one; you need r+ from flod/pascalc for the svn patch.

Comment 9

[Richard Newman [:rnewman]]

N.B., /mobile/ probably needs changing, too.

Comment 10

[Francesco Lodolo [:flod]]

Strings pushed and all locales updated in r120233.

Comment 11

[Benjamin Smedberg]

I don't see any UI or code for this on mobile. We only support one specific plugin, so it's not nearly as interesting.

Comment 12

[Laura Thomson :laura]

Comment on attachment 808664 [details] [diff] [review]
Plugin summary shouldn't use "enabled" and "disabled" but should use the terms which match the addon manager UI

Merged this way back, cleaning up in bugzilla

Comment 13

[Matt Brandt [:mbrandt]]

QA verified on dev

Comment 14

[Matt Brandt [:mbrandt]]

 Plugins

    always activate
    ask to activate
    never activate