Closed
Bug 919377
Opened 11 years ago
Closed 11 years ago
terminate build process if get error from xpcshell script
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yurenju, Assigned: yurenju)
Details
(Whiteboard: [good first bug][mentor=yurenju])
Attachments
(1 file)
after bug 917783, we can get error message from xpcshell script, but build process isn't terminated if we got error, we should re-throw this error to terminate build process.
|
||
Comment 1•11 years ago
|
||
I'd imagine you meant bug 917793 and the following changeset: https://github.com/mozilla-b2g/gaia/commit/e01e457dd6b8239b7ad8f712d0337e1d08db2208
|
Assignee | |
Comment 2•11 years ago
|
||
yes, so we need re-throw error to terminate build process :-)
|
|
Assignee | |
Comment 3•11 years ago
|
||
it's bug 917793 not bug 917783, thank you Alex!
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → yurenju.mozilla
|
|
Assignee | |
Comment 4•11 years ago
|
||
Alex, could you help to review this PR? thank you :-)
Attachment #810498 -
Flags: review?(poirot.alex)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 810498 [details] [review] github PR: https://github.com/mozilla-b2g/gaia/pull/12471 Sure, looks good!
Attachment #810498 -
Flags: review?(poirot.alex) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
merged. https://github.com/mozilla-b2g/gaia/commit/ad0285c8551bbd942687bdfd27886a2a919fa908
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•