919408 - Adding 'dummy-message' for testing system message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Henry Chang [:hchang]]

Attachment: Gecko-Adding-dummy-message.patch

For the developing system message testing framework 768228, it needs a specific system message for testing. Simply call it 'dummy-message'. Maybe we have to do more check to prevent from other apps using this testing message.

Comment 1

[Henry Chang [:hchang]]

Please see https://github.com/mozilla-b2g/gaia/pull/12556 for more information. We do need this dummy message for testing now. (The PR now is using 'media-button' for testing. After this lands, we can then change to using 'dummy-message')

Comment 2

[Gene Lian (I already quit Mozilla)]

Comment on attachment 808423 [details] [diff] [review]
Gecko-Adding-dummy-message.patch

Review of attachment 808423 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delayed response.

I think this is fine because system message is always fired from the central and cannot have chance to be hacked.

r=gene

::: dom/messages/SystemMessagePermissionsChecker.jsm
@@ +66,5 @@
>    },
>    "bluetooth-opp-transfer-start": {
>      "bluetooth": []
>    },
> +  "dummy-message": { },

I'd prefer s/dummy-message/dummy-system-message/ and please add a few comments to address the need.

"dummy-system-message": { }, // For the testing framework of system message.

Comment 3

[Henry Chang [:hchang]]

Attachment: Bug 919408 - Adding dummy message for testing

Comment 4

[Henry Chang [:hchang]]

Attachment: Bug 919408 - Adding dummy message for testing (name changed)

Comment 5

[Henry Chang [:hchang]]

Thanks Gene! I've changed the name and added the comment in the new attachment. Thanks.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/6e9ff87c4e97

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6e9ff87c4e97