919564 - shell/js-gdb.gdb catch handler has symbol error for __GI___sigaction

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

I don't know if this is a per-gcc/gdb version problem, but I get an error when the current signal handler is executed:
  No symbol "__GI___sigaction" in current context.
However, the symbol __sigaction works fine.  Does this symbol work for you also?

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

(In reply to Luke Wagner [:luke] from comment #0)
> I don't know if this is a per-gcc/gdb version problem, but I get an error
> when the current signal handler is executed:
>   No symbol "__GI___sigaction" in current context.
> However, the symbol __sigaction works fine.  Does this symbol work for you
> also?
I remember that the problem was you can't just use "sigaction" as it aliases the struct sigaction and gdb didn't know how to handle the difference.

I had sometimes errors that the symbol wasn't found, but not every time (maybe only when compiling with clang++). Using __sigaction works fine for me.

Comment 2

[Luke Wagner [:luke]]

Attachment: fix-js-gdb.gdb

Great, then let's try this.  This patch also fixes some sort of merge error introduced by http://hg.mozilla.org/mozilla-central/rev/2d2709188afa#l16.1

Comment 3

[Luke Wagner [:luke]]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=64ed8a633254

Comment 4

[Luke Wagner [:luke]]

Oops, I meant
https://hg.mozilla.org/integration/mozilla-inbound/rev/64ed8a633254

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/64ed8a633254