919567 - Stopwatch and Timer Panels do not update from underlying data objects

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Yannick Assogba [yannick_a] [tafsiri]]

In order to restore the stopwatch and timer state when the app starts, we need to be able to directly update the UI to a given state (started, paused, running, etc.). Currently the panels are primarily geared to changing state/appearance upon user interaction.

Comment 1

[Rick Waldron [:rwaldron]]

Requesting koi+

Without this patch, closing and re-opening the Clock app will appear to the user as though the app has lost any existing Timers or Stopwatches

Comment 2

[Yannick Assogba [yannick_a] [tafsiri]]

Do note however, that while this patch is to allow the Stopwatch and Panel UIs to match their underlying model objects, this bug doesn't track whether that object is coming from the persistence layer. For the bug tracking persistence itself see: https://bugzilla.mozilla.org/show_bug.cgi?id=910325, this patch is needed to solve that bug.

Comment 3

[Yannick Assogba [yannick_a] [tafsiri]]

Attachment: pull request for this bug for feedback

Comment 4

[Dylan Oliver [:doliver]]

(In reply to Yannick Assogba [yannick_a] [tafsiri] from comment #2)
> For the bug tracking
> persistence itself see: https://bugzilla.mozilla.org/show_bug.cgi?id=910325,
> this patch is needed to solve that bug.

So do we also need to nominate bug 910325 (and its dependencies) or can the persistence bugs be handled as a separate effort?

Comment 5

[Dylan Oliver [:doliver]]

triage: this is definitely bad and I think we should block on it, but depending on the answer to comment #4 we may have to re-evaluate if there are several persistence bugs to fix behind this one

Comment 6

[Rick Waldron [:rwaldron]]

(In reply to Dylan Oliver [:doliver] from comment #4)
> (In reply to Yannick Assogba [yannick_a] [tafsiri] from comment #2)
> > For the bug tracking
> > persistence itself see: https://bugzilla.mozilla.org/show_bug.cgi?id=910325,
> > this patch is needed to solve that bug.
> 
> So do we also need to nominate bug 910325 (and its dependencies) or can the
> persistence bugs be handled as a separate effort?

Dylan, thanks for taking a look at this. The persistence bugs can be handled separately. This bug is about restoring/reviving a persisted timer or stopwatch, not the actual persistence. Thanks again!

Comment 7

[Mike Pennisi [:jugglinmike]]

Comment on attachment 810116 [details] [review]
pull request for this bug for feedback

I've left some thoughts on the pull request. Feel free to flag me for review/feedback once you've incorporated the feedback (or sooner, if you have questions)!

Comment 8

[Yannick Assogba [yannick_a] [tafsiri]]

Comment on attachment 810116 [details] [review]
pull request for this bug for feedback

flagging for review

Comment 9

[Mike Pennisi [:jugglinmike]]

Comment on attachment 810116 [details] [review]
pull request for this bug for feedback

Hey Yannick,

Almost there!

Comment 10

[Mike Pennisi [:jugglinmike]]

Comment on attachment 810116 [details] [review]
pull request for this bug for feedback

Looking good, Yannick! I'll merge this for you in just a minute.

Comment 11

[Mike Pennisi [:jugglinmike]]

master: https://github.com/mozilla-b2g/gaia/commit/43c9c569d99f7124cc7c32afc96f52a97b3d4296

Thanks, Yannick!

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 43c9c569d99f7124cc7c32afc96f52a97b3d4296 to:
v1.2: 9e9c36012ae8f51d5edc53d313cad8a4d93bc6c0