Closed
Bug 919615
Opened 11 years ago
Closed 11 years ago
Add navigator.mozId automated test
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: edwong, Assigned: sebastiaan)
References
Details
Attachments
(2 files, 2 obsolete files)
Hi, the Persona/Identity team would like to add this persona app test, please review and merge: https://github.com/mozilla-b2g/gaia/pull/12339
Comment 1•11 years ago
|
||
Pointer to Github pull-request
Updated•11 years ago
|
Attachment #809796 -
Flags: review?(zcampbell)
Attachment #809796 -
Flags: review?(pdehaan)
Updated•11 years ago
|
Summary: Please Merge PR# 12339 - Add persona app test → Add persona app test
Comment 2•11 years ago
|
||
Comment on attachment 809796 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12339 r-, needs to be moved to the master/1.2 branch rather than v1-train. Also needs to be refactored to use the app objects properly. I put some basic comments in here but I didn't comment everywhere, just enough to explain the problem. See us in #mozwebqa if you want some more detailed advice and help.
Attachment #809796 -
Flags: review?(zcampbell) → review-
Reporter | ||
Comment 3•11 years ago
|
||
I refactored the test for 1.2, I issue a new PR: https://github.com/mozilla-b2g/gaia/pull/12519
Reporter | ||
Updated•11 years ago
|
Summary: Add persona app test → Add UI Tests navigator mozId automated test
Reporter | ||
Updated•11 years ago
|
Summary: Add UI Tests navigator mozId automated test → Add navigator.mozId automated test
Reporter | ||
Comment 4•11 years ago
|
||
test has landed - closing bug.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 5•11 years ago
|
||
We would like to have a version of this test for the v1.2 branch of gaia. The current version won't work against v1.2 because the UI Tests app is different. Reopening this bug so someone can take on the task of creating a version of this test that will run on v1.2.
Comment 6•11 years ago
|
||
Just to be clear, this bug is now about adding the test_persona_app test into the v1.2 branch.
Assignee: nobody → sebastiaan
Assignee | ||
Comment 8•11 years ago
|
||
Attachment #827418 -
Flags: review?(bob.silverberg)
Comment 9•11 years ago
|
||
Comment on attachment 827418 [details] [review] Bug 919615 - PR for missing persona test. Very nice pull request, Sebastiaan! Just a few comments to be addressed.
Attachment #827418 -
Flags: review?(bob.silverberg) → review-
Assignee | ||
Comment 10•11 years ago
|
||
Attachment #827418 -
Attachment is obsolete: true
Attachment #828027 -
Flags: review?
Assignee | ||
Comment 11•11 years ago
|
||
Attachment #828027 -
Attachment is obsolete: true
Attachment #828027 -
Flags: review?
Attachment #828155 -
Flags: review?(bob.silverberg)
Comment 12•11 years ago
|
||
v1.2 version landed in https://github.com/mozilla-b2g/gaia/commit/b4d59df5c3f974d9815e8f618e85266fc10a6c70
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment #828155 -
Flags: review?(bob.silverberg) → review+
Updated•10 years ago
|
Attachment #809796 -
Flags: review?(pdehaan)
You need to log in
before you can comment on or make changes to this bug.
Description
•