Closed
Bug 919672
Opened 11 years ago
Closed 11 years ago
lower the suspect referent count for the observer service's memory reporter
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: froydnj, Unassigned)
Details
Attachments
(1 file)
2.51 KB,
patch
|
n.nethercote
:
review+
wchen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•11 years ago
|
||
I have a couple score (hundreds?) of open tabs and have been noticing of late that the observer service has 4k+ observers for such a session. I was a bit surprised by this, and lowered the suspect referent count a bit to see if I could determine what was going on. There's nothing particularly unusual with my setup, but I'd like to propose that the count be lowered somewhat anyway. I think it's useful for about:memory to provide as much information as possible about what might be going on. I've also tried to update the explanatory text to indicate that merely having high counts is not necessarily symptomatic of a leak.
Attachment #808731 -
Flags: review?(n.nethercote)
Comment 2•11 years ago
|
||
Comment on attachment 808731 [details] [diff] [review] lower the suspect referent count for the observer service's memory reporter Review of attachment 808731 [details] [diff] [review]: ----------------------------------------------------------------- Seems ok to me, but I'll r? wchen, since he's the original author of this code.
Attachment #808731 -
Flags: review?(wchen)
Attachment #808731 -
Flags: review?(n.nethercote)
Attachment #808731 -
Flags: review+
Comment 3•11 years ago
|
||
Comment on attachment 808731 [details] [diff] [review] lower the suspect referent count for the observer service's memory reporter Review of attachment 808731 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/ds/nsObserverService.cpp @@ +148,5 @@ > nsIMemoryReporter::KIND_OTHER, > nsIMemoryReporter::UNITS_COUNT, > suspect.referentCount, > NS_LITERAL_CSTRING("A topic with a suspiciously large number " > + "referents. This may be symptomatic of a leak " There is a grammatical error in the original comment that might as well be corrected in this patch. larger number referents -> large number of referents.
Attachment #808731 -
Flags: review?(wchen) → review+
Reporter | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6aa2044de89d
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/6aa2044de89d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•