919705 - JSImplemented WebIDL interface methods should not be subject to needThisHandling checks

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Methods on JSImplemented WebIDL interfaces will sometimes cause IDL compilation errors due to triggering the needThisHandling property usually reserved for callbacks.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Don't ever claim that jsImplemented things are single-operation interfaces.

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 808785 [details] [diff] [review]
Don't ever claim that jsImplemented things are single-operation interfaces.

Review of attachment 808785 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/parser/WebIDL.py
@@ +812,5 @@
>      def isCallback(self):
>          return self._callback
>  
>      def isSingleOperationInterface(self):
>          assert self.isCallback() or self.isJSImplemented()

Ah, so I guess JS implemented stuff calls this (because it is callback-y), but shouldn't ever return true.  Makes sense.

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/45cdb4bf98ec

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/45cdb4bf98ec