91979 - 'Current Navigator Window' option in Open Web Location dialog is grayed out

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[shrirang khanzode]

today's branch 0723

steps:
launch composer
go to 'File|Open Web Location'
In the dialog that opens up, pull down the combobox labled "Open in"
select 'New Navigator window' and now retry selecting 'Current Navigator window'

Observe that the option is grayed out and you cannot select it anymore.

Comment 1

[rubydoo123]

handing over to cmanske, charley -- is this us or someone else?

Comment 2

[Kathleen :Brade]

Is there a current navigator window?  You're in a Composer window...
I would think that, at least sometimes, this menu item *should* be disabled.

Comment 3

[Charles Manske]

Kathy is right, but current code in openLocation.js disables the item all the
time. Technically not my bug, but it's clear how to fix it, so I'll take it.

Comment 4

[Charles Manske]

Attachment: Get current browser window when using dialog from Composer

Comment 5

[Charles Manske]

To verify:
1. Open Composer, close all browser windows.
2. Use Open Location dialog to open a URL into a "New Navigator window"
   ("Current Navigator window" menuitem should be disabled.)
3. Go back to composer window and use Open Location again, but "Current 
Navigator window" should be enabled - open another URL with that option.

I think Blake is the owner of this code now, so review is requested.
The only remaining problem I see is that focus is not shifted to browser 
window after the URL is loaded the second time (wheb "Current Navigator
window" was used.)
I tried this:
  setTimeout("browser.focus();", 100);
after the line:
  browser.loadURI(url);
but it didn't work

Comment 6

[Kathleen :Brade]

I think we need to change the string for that menu item/
To me, the "current window" is a Composer window, not a navigator window. 
 How about "Existing Navigator window"?  Other suggestions?

Comment 7

[Charles Manske]

It already is "Current Navigator window". I think that's fine.
Noting that, one could argue that current behavior is correct -- when you are in
Composer, there is no "current navigator".

Comment 8

[Charles Manske]

Robinf agrees with brade's suggested "Existing Navigator Window". 
That sounds good to me to avoid having to change the string only when 
launching the dialog from Composer.
Blake: This would change string for Navigator usage as well. Does this sound ok
to you?

Comment 9

[Charles Manske]

Attachment: Updated patch to include string change to "Existing Navigator window"

Comment 10

[Charles Manske]

Attachment: Alternate fix: Use "Existing Navigator window" only for Composer

Comment 11

[Blake Ross]

I like the Composer-only fix. sr=blake

Comment 12

[Charles Manske]

Attachment: Updated alternate fix: Must use "setAttribute" to change menuitem label

Comment 13

[Blake Ross]

Right. Missed that.  Actually, .label should work for menuitems, but that's a
separate bug.

Comment 14

[Kathleen :Brade]

r=brade on the most recent patch (provided the *.properties file is also checked
in with it)

Comment 15

[Charles Manske]

checked in.

Comment 16

[James Baxter]

Verified on 8-30 build