919834 - [Buri] Unable to toggle Default Media Location

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Marcia Knous [:marcia]]

Attachment: defaultmedia.txt

Buri, while using:

Gaia   3408cc3f6b190c8cd31832fbb8cd2ae571041f29
SourceStamp f97307cb4c95
BuildID 20130923040214
Version 27.0a1

STR:
1. Download some content to test forward lock.
2. Go to Settings | Media Storage. Observe that the default media location is set to SD card.
3. In the advanced section try to toggle the default media location


Expected: I could toggle between SD card and Internal Memory
Actual: It remains as the default - SD Card and I cannot change to internal memory

Logcat attached.

I checked on 1.2 and the issue exists as well there. Works fine using the latest 1.1 build. On Mozilla Central even if I reset the phone the issue still persists.

Comment 1

[Marcia Knous [:marcia]]

Although maybe I am hitting Bug 873247?

Comment 2

[Dave Hylands [:dhylands]]

Currently, the only devices which have multiple storage areas are the leo and helix. All of the other devices only have a single storage area (which is either the external sdcard (unagi/buri/inari) or internal storage (nexus s/nexus 4).

I think that for the case where there is only a single storage area that it might make sense to not show the control which allows the default storage area to be selected, but that's really a UX decision.

Comment 3

[Dave Hylands [:dhylands]]

I closed bug 873247 as invalid since there is only one storage area.

I left this one open in case we'd like to persue having the settings changed.

Comment 4

[Lucas Aliaga]

Tested as far back as 6/21 1.2 build and the issue still occurs. "Default media location" option appears even though there is only one storage location.

- Issue occurs 6/21 1.2 -
Build ID: 20130621031231
Gecko: http://hg.mozilla.org/mozilla-central/rev/7ba8c86f1a56
Gaia: e2f19420fa6a26c4287588701efaec09a750dba1
Platform Version: 24.0a1

Comment 5

[Ivan Tsay (:ITsay)]

Hi CJ,

Do you know which team is working on the forward lock gaia part?

Comment 6

[Dave Hylands [:dhylands]]

Hi Ivan,

I believe djf is working on that (media team).

Comment 7

[u459114]

(In reply to Dave Hylands [:dhylands] from comment #6)
> Hi Ivan,
> 
> I believe djf is working on that (media team).

Yes, that's what I know as well

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

David, could you comment the bug and judge it's blocking status?

Comment 9

[David Flanagan [:djf]]

It is bad to make the user think that there is internal memory available when there isn't.  On devices that have only one storage area, the settings app shouldn't show an option to change.

If I was in in a triage meeting about this, I'd want to make it koi+.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Who we should assign this bug to?

Comment 11

[David Flanagan [:djf]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #10)
> Who we should assign this bug to?

Evelyn and Kaze are the modules owners. Maybe then can take it or assign it.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Kaze, do you know how worked on forward lock and touched this part of code recently? Thanks.

Comment 13

[Evelyn Hung]

I don't think the issue is related to forward lock (I don't know it though), and agree with comment 2: it's a UX decision, and we (as engineer) have a discussion before (bug 874313 comment 47), need UX input now.

Comment 14

[Evelyn Hung]

BTW, I can mentor someone to fix the issue after having UX input.

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

UX detail, -'ing...

Comment 16

[Neo Hsieh [:neo]]

Per talked with Arthur, My suggestion is to remove "Advanced" whole category when the user doesn't have any choice. (Only internal memory or only SD card) And also change 4 related App's (Video,Music,Camera,Gallery) pop up the message wording, remove pop-up messages' button (Go to Advanced). 

Does it make sense to you ? Any comments are welcome.

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

Tzu-lin, are you interested in this UI bug?

Comment 18

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Ok, let me take care of this.

Comment 19

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

Hi Evelyn, 
  Please kindly help to review the settings part. Thanks

Hi David,
  Please kindly help to review the apps part(Camera, Gallery, Video, and Music). Thanks

Comment 20

[Evelyn Hung]

Comment on attachment 817714 [details]
pull request

r- because the change (in Settings app) is not on a correct direction. Please see my comment on Github. Thanks.

Comment 21

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 817714 [details]
pull request

Hi Evelyn,
I've updated pull request as your comments.
Please help to review it again.

Thanks

Comment 22

[Evelyn Hung]

Comment on attachment 817714 [details]
pull request

r+ on Settings part with two nits be addressed. Thanks!

Comment 23

[David Flanagan [:djf]]

Comment on attachment 817714 [details]
pull request

I left a couple of comments on github.

I'd slightly prefer that you don't define a new variable in the media apps and just do 

  if (navigator.getDeviceStorage(type).length <= 1)

Also, I'd prefer if you used "nocard-nointmem" or something like that instead of "nochoice".

In fact, I wonder if we need two separate cases at all. On devices that have internal memory, I didn't think we could ever get into the "nocard" state. Would we ever actually see the "nocard" message and button on those devices?  If not, then we don't need separate "nocard" and "nochoice" overlays.  Making that change now might be too risky if you hope to uplift this, however.

Comment 24

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Hi David,

Thanks for the review. 
For media apps which depends on MediaDB (Gallery, Video, and Music), I agree with your point that we will never be in 'nocard' state since no volume is available when MediaDB says it is in MediaDB.NOCARD state. But I cannot be sure of this would ever happen in Camera app.

I'll fix the Gallery, Video, Music app with only one 'nocard' stat and investigate if this also works on Camera app.

Comment 25

[Evelyn Hung]

(In reply to Tzu-Lin Huang [:dwi2] from comment #24)
> Hi David,
> 
> Thanks for the review. 
> For media apps which depends on MediaDB (Gallery, Video, and Music), I agree
> with your point that we will never be in 'nocard' state since no volume is
> available when MediaDB says it is in MediaDB.NOCARD state. But I cannot be
> sure of this would ever happen in Camera app.
> 
> I'll fix the Gallery, Video, Music app with only one 'nocard' stat and
> investigate if this also works on Camera app.

I think we can open a follow-up bug because it's another issue. :)

Comment 26

[Tzu-Lin Huang [:dwi2][:tzhuang]]

I just tried this patch on Helix (which has enough large internal storage and sdcard slot)
Steps:
1. Set default media storage location to SD card while SD card is inserted
2. Remove SD card
3. Open Camera/Gallery/Music/Video app

In Gallery, Music, and Video apps, it automatically search content from internal storage. (Though its default media location is SD card )
However in Camera app, it did enter 'nocard' state and poped up message 'Insert a memory card to take pictures or select an alternate default media location in settings.'

So I think separation of 'nocard-nointmem' state from 'nocard' state in Camera app is necessary, but no necessary in three other apps.

I'll fix this part in the patch because the inaccessible state is cause by this patch.

Comment 27

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 817714 [details]
pull request

Hi David,

I've update the patch. 
Now there is one 'nocard' state in Gallery, Music, and Video app. (No 'nocard-nointmem' state anymore in these three apps)
Only Camera app has both 'nocard' and 'nocard-nointmem' state.

Please kindly help to review it again. Thanks

Comment 28

[BMO Automation]

Firefox OS is not being worked on