91984 - default search engine name should be in the US.jar instead of en-US.jar

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P2)

Description

[Ying-Lin Xia]

In the navigator.properties, line 34, there is a definition for the default 
search engine.
   browser.search.defaultenginename=Netscape Search
This entity should not in the language pack.

We are having a problem with Japanese localization. In the Netscape Japanese 
search engine sherlock file, the name is Netscape Search Japan. With different 
names in the navigator.properties and the sherlock file, the sidebar search 
panel won't displayed properly.

See bugscape 7842 for screenshots.

Do you have any bug for this issue already? Sorry for duplicate if there was.

Comment 1

[tao]

It seems to me that the inconsistency causes this bug instead of the location of
the default search engine setting. Is moving this prefs value the only solution
to this problem? Why not just leave the prefs there and make sure the names are
consistent every where?

Comment 2

[Ying-Lin Xia]

I think this entity should be in the region pack instead of the language pack.

Comment 3

[tao]

change summary to reflect the destination file names.

Comment 4

[Greg K.]

If Platform=All, then OS=All.

Comment 5

[Christian Reis]

Changing to NEW based on confirmation. Changed component to Internationalization
since it affects language packs.

Comment 6

[Roy Yokoyama]

I am not sure who should own this bug.  
Trying Tao and cc'ing ftang and myself.

Comment 7

[Michele Carlson]

yxia to check this out.

Comment 8

[Ying-Lin Xia]

This string is still in the language pack. The issue is still open:

For l10n, when we change a default search engine in the region pack (US.jar), 
we have to change the default search engine name in the language pack 
(en-US.jar).

This causes:
1) When user installed a region pack, and use that region to create a new 
profile, the default search engine can not be the one in region pack.
2) Makes l10n process un-easy.

Comment 9

[tao]

reassign to new owner ->dbragg

Comment 10

[Ying-Lin Xia]

We can move the default search engine into region pack with the following patch. 
Can we?

Comment 11

[Ying-Lin Xia]

Attachment: patch to move the engine entity into region pack

Comment 12

[tao]

Comment on attachment 62286 [details] [diff] [review]
patch to move the engine entity into region pack

looks right; pls test all UI components to make sure you do not break anything

Comment 13

[Ying-Lin Xia]

Did more test, looks fine to me.

Comment 14

[Jimmy Uen]

Update QA to [e-mail]

Comment 15

[tao]

Comment on attachment 62286 [details] [diff] [review]
patch to move the engine entity into region pack

looks good

Comment 16

[Alec Flett]

Comment on attachment 62286 [details] [diff] [review]
patch to move the engine entity into region pack

man, that's a lot of context? what is that diff -u10? :)

Comment 17

[dbragg]

Fix checked in.

Comment 18

[dbragg]

Typo in checkin causes search to fail from URL bar.  See bug 124906.

Comment 19

[dbragg]

*** Bug 124906 has been marked as a duplicate of this bug. ***

Comment 20

[dbragg]

Checked in.  r=sgehani

Comment 21

[Claudius Gayle]

the duplicate - bug 124906 is still showing up in the smoketest results. It is
either not a duplicate or this bug is not entirely fixed.

Comment 22

[dbragg]

I didn't know there was an NS part of this bug.  Fix was the same as the mozilla
bits except for the all.js file.  Fix checked in.

Comment 23

[dbragg]

Attachment: Removal of browser.search.defaultenginename from region.properties

Comment 24

[dbragg]

Attachment: addition of browser.search.defaultenginename to region.properties

Comment 25

[dbragg]

Sorry, the patch descriptions should be reversed.  69587 is the addition of
browser.search.defaultenginename to region.properties and 69589 is the removal
of it from navigator.properties.

Comment 26

[Jimmy Uen]

Verified with 2002-04-04-03-trunk