919840 - Use WebIDL codegen to implement WebRTC events

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: untested wip

Let's see if #includes work ok even in case some interfaces are implemented in js.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

https://tbpl.mozilla.org/?tree=Try&rev=ac74d66833f7

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 808923 [details] [diff] [review]
untested wip

At least it compiles. Crossing fingers that tests will be passed.

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 808923 [details] [diff] [review]
untested wip

Review of attachment 808923 [details] [diff] [review]:
-----------------------------------------------------------------

Appears to work and passes mochitests locally. One nit in manifest. r+ assuming try goes well

Try - https://tbpl.mozilla.org/?tree=Try&rev=06f61aeb8cba

::: dom/media/PeerConnection.manifest
@@ +5,3 @@
>  component {b9cd25a7-9859-4f9e-8f84-ef5181ff36c0} PeerConnection.js
>  component {a722a8a9-2290-4e99-a5ed-07b504292d08} PeerConnection.js
>  component {d5ed7fbf-01a8-4b18-af6c-861cf2aac920} PeerConnection.js

You should probably remove these three uuids, though it doesn't appear to affect things.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: gen_webrtc_events_2.diff

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc2423699bd5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dc2423699bd5