Closed Bug 919924 Opened 11 years ago Closed 3 years ago

Make encodings type-safe

Categories

(Core :: Internationalization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: hsivonen, Unassigned)

References

Details

Currently, we use nsACString both for encoding labels and encodings. If we had  a special type for encodings, it would be more obvious which values are labels that must be resolved into encodings before use and which are encodings that must not be re-resolved to avoid the fact that "replacement" is an encoding but unknown as a label.
Depends on: encoding_rs
Bug 1261841 has landed. It adds const mozilla::Encoding* for this purpose. Next we need to use it everywhere.
Depends on: 1373984
Depends on: 1374629

Let's consider mozilla::Encoding* sufficiently in use by now.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.